From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2f.google.com (mail-vs1-xe2f.google.com [IPv6:2607:f8b0:4864:20::e2f]) by sourceware.org (Postfix) with ESMTPS id CFBAF3858D1E for ; Wed, 10 Aug 2022 13:04:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CFBAF3858D1E Received: by mail-vs1-xe2f.google.com with SMTP id c3so15031734vsc.6 for ; Wed, 10 Aug 2022 06:04:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=fOhYw840WtHDzZTO3uYoE8H85x3H7b/6A8w7cbmwny8=; b=dnm1R12EWfzAtMRRKpkZ28Kb1Jbz2xepAKkNMNObpph8lwGr2xlMAXc26eveUVXrQO 36AVnjwfYL8oSrNEDKzWpGXmyCb/pnwfadckMV1xPqWGvMuSqxXIOzZKeJ4vDy1CEpCS cG3QVVF0kY9jaQSpJtQGGopJns6zS3AJpc5btVu8fBgGRuGjE1EFgJwhtfaQNQ7svdN/ B2kZvoLSzQqCVAdWbHGtN+B39QUEO62xW5Xv+mXkXebx43HXwqs8BWcz4LTg6teRzus7 DvyoH1+MG3GIXjH0qIsmdMNEUFz3gtg50sthCQpoTdvCV9W/8pvdVKT+/VNpndK8V+U+ SRhg== X-Gm-Message-State: ACgBeo0YKZ1rWVyVy4vjn7fjbj3v57R00NGTbSvWQGLh6ifJHE0LIPGD MRr3E727o6U3mvJmeAQkcLKGCCnGb6hvTA== X-Google-Smtp-Source: AA6agR5NgsCx/tuoTMId1AX5Xz9UYI0hmNso2Ai/935BWoG/v7bmN5v5VoTnEBextwVQ4t6WaNDp8Q== X-Received: by 2002:a67:b604:0:b0:388:574b:977 with SMTP id d4-20020a67b604000000b00388574b0977mr10913508vsm.60.1660136648734; Wed, 10 Aug 2022 06:04:08 -0700 (PDT) Received: from ?IPV6:2804:431:c7ca:930b:c8c3:715b:6901:2e81? ([2804:431:c7ca:930b:c8c3:715b:6901:2e81]) by smtp.gmail.com with ESMTPSA id n3-20020ab04483000000b00384ddcfcf6asm13014433uan.8.2022.08.10.06.04.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Aug 2022 06:04:08 -0700 (PDT) Message-ID: Date: Wed, 10 Aug 2022 10:04:06 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.1 Subject: Re: [PATCH] elf: Remove -fno-tree-loop-distribute-patterns usage on dl-support Content-Language: en-US To: Noah Goldstein Cc: GNU C Library References: <20220808200021.763123-1-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 13:04:11 -0000 On 10/08/22 00:37, Noah Goldstein wrote: >> #endif >> diff --git a/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S >> index ac4b2d2d50..034d19b35e 100644 >> --- a/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S >> +++ b/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S >> @@ -44,4 +44,7 @@ >> >> # define USE_LESS_VEC_MASK_STORE 1 >> # include "memset-vec-unaligned-erms.S" >> +# if !defined NO_MULTIARCH && MINIMUM_X86_ISA_LEVEL >= 4 >> +strong_alias (__memset_evex_unaligned, __memset_generic) >> +# endif > > Instead of adding aliases in each file can't you just add one alias > at the end of multiarch/rtld-memset.S? > > Might be cleaner. Generally prefer keeping all the alias stuff > out of the implementation files if possible. The problem is not really the loader since we do not support calling ifunc from it (that's why multiple ports have rtld-* overrides), the issue is the initialization for static where either functions call are not possible (dl-tunables.c) or ifunc calls are not possible (dl-support.c). In any case, I am experiment with H.J. suggestion to alias to a per-arch symbol instead of add a generic one.