From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6ACA03881D13 for ; Mon, 13 Feb 2023 14:23:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6ACA03881D13 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676298190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k7HiELP5w519JNlGVbBpVTP07dq61DO206uWu20KRsc=; b=Dhj4RjFEUosC59PGDHwPQMOc2h+rvVIlXICoEC9LcwUKxCaZBwKoCFPAMGrQh24rdg7JQ3 ZNpoQ1+LJZ9DYUiLYs5nbsrrvRONgK7DUeEnEosjld7IL2t492erfT754FF7WhFdx2fbl7 9wSfyKcVryz2facFhtp4oCuLt5Lul10= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-584-XgR_xhwiNSa642vDKX0rsA-1; Mon, 13 Feb 2023 09:23:09 -0500 X-MC-Unique: XgR_xhwiNSa642vDKX0rsA-1 Received: by mail-il1-f199.google.com with SMTP id l7-20020a056e020dc700b0031534e3f1dbso3179962ilj.2 for ; Mon, 13 Feb 2023 06:23:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k7HiELP5w519JNlGVbBpVTP07dq61DO206uWu20KRsc=; b=ZQ+WUpZ+fKFTJTXVn/5RIXUNKFVN91yl3am2zJsqjJP733Au4oz99NJXM67a2UF40u su70Byfe/bmEmMifxcfTickExXb3XkfeghC6Go9mbqVTK23wmgLZtUEU6TMvHK4HEJ4s 5QeJjEnAlFW9LaQXoGr9a40Qb4C2PO6QoxikGujT7zoqXHfPDYGytqkzWjrWOR3Sb3Tt 1JgZUp99eNU1QFrB7qyUtQ8q+9ca97euU6ntQ/pCF9m/aHQmNndlhWh+Fia5Z7uxMb5o +MB40EnaNAZghYd+hVlIWer9Cfyb65ty5RtGesJfbNwTZQPEZOGdu1kcabFbsrLqRhKW Pg1w== X-Gm-Message-State: AO0yUKUg5sCGu5mxb4yg+bR12Rb8zqpziV4NRTp3EM+7vHxKF6TVJY1z uyipYn54YkkR0y+gPfmBpuntWmMcef0u6n2yue7RPTx/p1zxYx8Bny6IS3r/DIpWTPB3HRPqYYE WUxDjGl5lx6+dd4LME9bo/M9b5w== X-Received: by 2002:a92:1a54:0:b0:315:21d1:760b with SMTP id z20-20020a921a54000000b0031521d1760bmr9514539ill.1.1676298186972; Mon, 13 Feb 2023 06:23:06 -0800 (PST) X-Google-Smtp-Source: AK7set9KTGMfiPtjlXIotx45EtelOps0jsYEqwCzMg/3JXwzOUfu79vRYI8NuVTMhqR/VBsa6gUMIQ== X-Received: by 2002:a92:1a54:0:b0:315:21d1:760b with SMTP id z20-20020a921a54000000b0031521d1760bmr9514531ill.1.1676298186795; Mon, 13 Feb 2023 06:23:06 -0800 (PST) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id k26-20020a02c65a000000b0039e5786d7b7sm4014717jan.18.2023.02.13.06.23.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 06:23:06 -0800 (PST) Message-ID: Date: Mon, 13 Feb 2023 09:23:05 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [committed][PATCH] Use __builtin_FILE instead of __FILE__ in assert in C++. To: Joseph Myers , Paul Pluzhnikov Cc: Andreas Schwab , Paul Pluzhnikov via Libc-alpha References: <20230210162626.3097660-1-ppluzhnikov@google.com> <87mt5lo3nm.fsf@igel.home> <9030e0a4-4178-6d0-efee-dd736137cab4@codesourcery.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <9030e0a4-4178-6d0-efee-dd736137cab4@codesourcery.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/10/23 16:56, Joseph Myers wrote: > On Fri, 10 Feb 2023, Paul Pluzhnikov via Libc-alpha wrote: > >> I was able to push amended patch (since there were no newer commits). >> Is that what I should have done? > > No, you should never do non-fast-forward pushes to master or other shared > branches. Carlos, could you investigate why the allow-non-fast-forward = > (?!master|release.*) setting wasn't working to prevent such a push? Is > the setting being matched against full ref names and so considering > refs/heads/master to match (?!master|release.*)? > Yes, I'll look at this. This shouldn't be allowed. -- Cheers, Carlos.