From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128733 invoked by alias); 20 Jan 2018 08:36:44 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 128716 invoked by uid 89); 20 Jan 2018 08:36:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Calendar, abbreviated, commas, opinion X-HELO: smtp.pacific.net Subject: Re: [PATCH v12 5/6] Documentation to the above changes (bug 10871). To: Rafal Luzynski , libc-alpha@sourceware.org References: <1802414843.37687.1515744747279@poczta.nazwa.pl> <1927758682.38060.1515745107778@poczta.nazwa.pl> <49ea50a9-3cca-bbfe-8c75-41ea603d1a58@pacific.net> <232736801.586762.1516016805848@poczta.nazwa.pl> From: Rical Jasan Message-ID: Date: Sat, 20 Jan 2018 08:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <232736801.586762.1516016805848@poczta.nazwa.pl> Content-Type: multipart/mixed; boundary="------------3F975AFF56A8923049B9D212" X-SW-Source: 2018-01/txt/msg00677.txt.bz2 This is a multi-part message in MIME format. --------------3F975AFF56A8923049B9D212 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-length: 1222 On 01/15/2018 03:46 AM, Rafal Luzynski wrote: > Can I suggest that if there are no issues beyond the documentation > (yes, I know that whether we add _NL_ABALTMON_* or __ABALTMON_* and > ABALTMON_* is a serious API issue) then please let's commit this ASAP > to make sure we have those remaining 2 weeks to announce the change > to the outer world and let's polish the documentation within this > period? Here's a patch with my suggestions for the documentation; it should apply on top of yours if you'd like to merge it in (or I can push it later; I don't have a strong opinion). I mention that an ABALTMON equivalent for %Ob isn't provided, but is expected, and that _NL_ABALTMON may be used in the meantime. I'm not sure if we want to say it quite that way, but it's a start. That was my mistake about "@:" being a colon. That's what I get for reviewing with the Texinfo manual out of hand. :) I think Texinfo handles the comma after the period properly, as I couldn't tell a difference in the rendered output either way, but it doesn't hurt to give it hints, so I left it in. I did add commas before "etc." though. I agree that if it's documentation minutiae holding this up, the patches should go in. Rical --------------3F975AFF56A8923049B9D212 Content-Type: text/x-patch; name="altmon-docs.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="altmon-docs.patch" Content-length: 2489 diff --git a/manual/locale.texi b/manual/locale.texi index 059db75c1c..19b1cfc421 100644 --- a/manual/locale.texi +++ b/manual/locale.texi @@ -923,7 +923,7 @@ corresponds to Sunday. @itemx DAY_5 @itemx DAY_6 @itemx DAY_7 -Similar to @code{ABDAY_1} etc.,@: but here the return value is the +Similar to @code{ABDAY_1}, etc.,@: but here the return value is the unabbreviated weekday name. @item ABMON_1 @itemx ABMON_2 @@ -952,7 +952,7 @@ corresponds to January. @itemx MON_10 @itemx MON_11 @itemx MON_12 -Similar to @code{ABMON_1} etc.,@: but here the month names are not abbrevi= ated. +Similar to @code{ABMON_1}, etc.,@: but here the month names are not abbrev= iated. Here the first value @code{MON_1} also corresponds to January. @item ALTMON_1 @itemx ALTMON_2 @@ -966,13 +966,19 @@ Here the first value @code{MON_1} also corresponds to= January. @itemx ALTMON_10 @itemx ALTMON_11 @itemx ALTMON_12 -Similar to @code{MON_1} etc.,@: but here the month names are in the gramma= tical +Similar to @code{MON_1}, etc.,@: but here the month names are in the gramm= atical form used when the month is named by itself. The @code{strftime} functions -use these month names for the format specifier @code{OB}. +use these month names for the conversion specifier @code{%OB} +(@pxref{Formatting Calendar Time}). =20 Note that not all languages need two different forms of the month names, so the strings returned for @code{MON_@dots{}} and @code{ALTMON_@dots{}} may or may not be the same, depending on the locale. + +@strong{NB:} @code{ABALTMON_@dots{}} constants corresponding to the @code{= %Ob} +conversion specifier are not currently provided, but are expected to be in= a +future release. In the meantime, it is possible to use +@code{_NL_ABALTMON_@dots{}}. @item AM_STR @itemx PM_STR The return values are strings which can be used in the representation of t= ime diff --git a/manual/time.texi b/manual/time.texi index 2a5afd9e56..6c3d5e9ab2 100644 --- a/manual/time.texi +++ b/manual/time.texi @@ -1349,7 +1349,7 @@ Emperors' reigns. With all format specifiers that produce numbers: use the locale's alternate numeric symbols. =20 -With @code{%B} and @code{%b}: use the grammatical form for month names +With @code{%B}, @code{%b}, and @code{%h}: use the grammatical form for mon= th names that is appropriate when the month is named by itself, rather than the form that is appropriate when the month is used as part of a complete date. This is a GNU extension. --------------3F975AFF56A8923049B9D212--