From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75430 invoked by alias); 19 Apr 2018 19:25:38 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 75418 invoked by uid 89); 19 Apr 2018 19:25:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=folders X-HELO: mail-qt0-f175.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=q8cbf4N2cbzkoVKY4AMOg4DqO9ulWGY486ua1jFNrgc=; b=dgilC9qi26FweQhC4Qt4KFIyzXouAK59ykQ3Di/yri0T1QjM4cE8IyrOeri92csn6F xpNtk/C3r0naQyhSPKPYYKYOjTq+QBRKVu9MI0vL5zh7uEF9L/E7JcZc9804LlX0QME9 vYMfUon0FEvU895NAj+9upWg/S5WssB2Xu44EVAUbGlwkFJl2kqs0b+x6VWVfs/hLxi9 7gR82gEZVzDFgkVlxXZaPjGe55mGcVblY63cHXg0EIqq9wDUpPhctS5xgcMLZmgdrYyY q/abLal+HMI6+jxdz2qRmpC3JV437nxJWlcjGaqSS3ClfQjBP8KE9hnQiifyPLwvJM5G F93Q== X-Gm-Message-State: ALQs6tDK1crl9bQkk3hB7/r+1FZRFpwAjVTtCi0BpFlc6g0iA+FGoeOR WSjvoccFsXQwxF3HOaEo0JvLiGzG2Io= X-Google-Smtp-Source: AB8JxZo478NIY4puVK30t/sfbea3biVlnAwGNuGSq/WAb+h54ILryIjicc/jIxxhfU3DG7WU3ipxTQ== X-Received: by 2002:ac8:256f:: with SMTP id 44-v6mr7656118qtn.239.1524165933568; Thu, 19 Apr 2018 12:25:33 -0700 (PDT) Subject: Re: aarch64: add HWCAP_ATOMICS to HWCAP_IMPORTANT To: Szabolcs Nagy , libc-alpha@sourceware.org Cc: nd@arm.com References: <1d8eb765-e147-534e-ed1e-daa8deb8d5a7@arm.com> <02df4e53-258f-ea9c-1381-4420061f7031@arm.com> From: Adhemerval Zanella Openpgp: preference=signencrypt Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= xsFNBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABzUlBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+wsF3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AqzsFNBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABwsFfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: Date: Thu, 19 Apr 2018 19:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <02df4e53-258f-ea9c-1381-4420061f7031@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-04/txt/msg00429.txt.bz2 On 19/04/2018 14:06, Szabolcs Nagy wrote: > On 19/04/18 15:38, Adhemerval Zanella wrote: >> On 19/04/2018 08:51, Szabolcs Nagy wrote: >>> This enables searching shared libraries in atomics/ when the hardware >>> supports LSE atomics of armv8.1 so one can provide optimized variants >>> of libraries in a portable way. >>> >>> LSE atomics does not affect library abi, the new instructions can >>> interoperate with old ones. >>> >>> I'm not familiar with how this feature of the dynamic linker is used >>> in practice by distros or others so comments are welcome. >> >> Clearlinux seems to use this to provide optimized Intel libraries [1]. >> > > interesting thanks. > >>> 2018-04-19  Szabolcs Nagy  >>> >>>      * sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h (HWCAP_IMPORTANT): Add >>>      HWCAP_ATOMICS. >> >> I think what you want is something what x86_64 has done [2]: on cpu-features.c >> the code creates a list of possible processor specific paths and sets it do >> GLRO(dl_platform) (for instance on x86_64 if the underlying system is a haswell >> it will add the haswell folder path). >> >> Currently since AArch64 do not change dl_platform_init, it adds 'aarch64' from >> AT_PLATFORM and 'cpuid' because of HWCAP_IMPORTANT.  IMHO neither does make >> sense as search paths, I would expect at least the 'cpu_list' from aarch >> cpu-features.c (maybe by excluding the 'generic' field). >> > > i don't know the reasons behind 'aarch64' and 'tls' search paths > and i have no particular attachment to the HWCAP_IMPORTANT mechanism. 'aarch64' came from default code at elf/dl-sysdep.c if the platform does not override the dl_platform (and the code to set AT_PLATFORM on dl_platform is from commit 0a54e401). My guess is to provide a direct way to difference ABI folders for bi-arch system (x86_64 and i686 for instance). I think for aarch64 there is no direct gain in adding 'aarch64' in search path. > >> So I suggest to rework how aarch64 obtain the search path by setting the >> dl_platform in cpu-features.c: >> >>    - We can get the cpu_list if HWCAP_CPUID, so add only current cpu folder >>      if it the case. >> >>    - If HWCAP_ATOMICS is set add 'lse'. >> > > if these paths are for optimization only then i guess the list > can change between libc releases without causing issues other > than performance regressions. > > in that case i'm in favor of removing unnecessary search paths. > > atomics i think is a useful variant, i'll think about the cpuid > based search paths, i don't want too many variants since nobody > will prepare/test binaries for all uarch variants, but i do like > the ability to have alternative optimized libs. I think adding just 'lse' (or other meaningful name) should be suffice for now. If cavium/qualcomm/etc desire, they can propose adding more search paths based on their requirements. > >>    - Any more required? >> >> [1] https://clearlinux.org/blogs/transparent-use-library-packages-optimized-intel-architecture >> [2] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=1432d38ea04ab5e96f21a38;hp=3b5f801ddb838311b5b05c218caac3bdb00d7c95 >> >