From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id EF0243858C53 for ; Tue, 5 Apr 2022 11:16:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EF0243858C53 Received: by mail-ot1-x32d.google.com with SMTP id b17-20020a0568301df100b005ce0456a9efso9141151otj.9 for ; Tue, 05 Apr 2022 04:16:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=7WUk4FZAmOA7bkMdL/51Rd92iGJo7itkFu+NJ4Q230I=; b=M6pm71JlvuF18Rco2xWs7rYV8TwdKaNfLSizpV8mHmEl7j9ExYgvRtK8cUzS9dwB8C 4Fh49hLSRYdUa5s/bhfl38pOaE634sysh1oYAshEM/YxaenEeaomPrZQER73+viyRWvr oAzLsxmejZXhfZzu2OF98BTrk0+1OYEPK3q9FBwOCVwOhHNfDmzoq0UO9kKI43Uv3Q9g lkZ77vCIz9o/5QJuS4siZR9XDxSDfBRFs7Lrc3SUdvpYkCDMHbA/Dk3lMEy3mRzA8/FT 9jFJALdSFq8AyuNLtj27UxQnoSF4la98DH7Qtb3SZ1FkfD6eRzSZT+3/AIgZlcE6Oxmk KGBQ== X-Gm-Message-State: AOAM533FkyNif5GO5ujsdPlXcNtNGQSHJi6dJD6w/GgKwDSJTMyS++LM EXWYmVc9lW7dTQ+PdZQzHbrw/Q== X-Google-Smtp-Source: ABdhPJzoFxR/3apfNmLmUqE+GcaGE3byPJDVSTr4sbYaW//4dLGvljwPKgkq/xgZt5S5f7LSQJgGAw== X-Received: by 2002:a9d:1924:0:b0:5e6:8d56:748e with SMTP id j36-20020a9d1924000000b005e68d56748emr993834ota.41.1649157418149; Tue, 05 Apr 2022 04:16:58 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:a6c0:26f4:3c2a:73ae:3e2? ([2804:431:c7cb:a6c0:26f4:3c2a:73ae:3e2]) by smtp.gmail.com with ESMTPSA id p12-20020a4a95cc000000b003246cd15eaasm4851842ooi.2.2022.04.05.04.16.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Apr 2022 04:16:57 -0700 (PDT) Message-ID: Date: Tue, 5 Apr 2022 08:16:54 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] manual: Avoid name collision in libm ULP table [BZ #28956] Content-Language: en-US To: Tom Coldrick , libc-alpha@sourceware.org References: <20220405094654.111306-1-thomas.coldrick@codethink.co.uk> From: Adhemerval Zanella In-Reply-To: <20220405094654.111306-1-thomas.coldrick@codethink.co.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2022 11:17:00 -0000 On 05/04/2022 06:46, Tom Coldrick via Libc-alpha wrote: > The 32-bit and 64-bit variants of RISC-V share the same name - "RISC-V" > - when generating the libm error table for the info pages. This > collision, and the way how the table is generated, mean that the values > in the final table for "RISC-V" may be either for the 32- or 64-bit > variant, with no indication as to which. > > As an additional side-effect, this makes the build non-reproducible, as > the error table generated is dependent upon the host filesystem > implementation. > > To solve this issue, the libm-test-ulps-name files for both variants > have been modified to include their word size, so as to remove the > collision and provide more accurate information in the table. > > An alternative proposed was to merge the two variants' ULP values into a > single file, but this would mean that information about error values is > lost, as the two variants are not identical. Some differences are > considerable, notably the values for the exp() function are large. Path looks ok, but is there any expectation that RV64 and RV32 hardware floating-point implementation or compiler generate code to have different precision? Otherwise it would be simple to just use one ulp tests file. > --- > sysdeps/riscv/rv32/rvd/libm-test-ulps-name | 2 +- > sysdeps/riscv/rv64/rvd/libm-test-ulps-name | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sysdeps/riscv/rv32/rvd/libm-test-ulps-name b/sysdeps/riscv/rv32/rvd/libm-test-ulps-name > index 827fcdca19..6d2816082e 100644 > --- a/sysdeps/riscv/rv32/rvd/libm-test-ulps-name > +++ b/sysdeps/riscv/rv32/rvd/libm-test-ulps-name > @@ -1 +1 @@ > -RISC-V > +RISC-V 32-bit > diff --git a/sysdeps/riscv/rv64/rvd/libm-test-ulps-name b/sysdeps/riscv/rv64/rvd/libm-test-ulps-name > index 827fcdca19..9cb50380df 100644 > --- a/sysdeps/riscv/rv64/rvd/libm-test-ulps-name > +++ b/sysdeps/riscv/rv64/rvd/libm-test-ulps-name > @@ -1 +1 @@ > -RISC-V > +RISC-V 64-bit