public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org, Joe Simmons-Talbott <josimmon@redhat.com>
Subject: Re: [PATCH] resolve: Remove __res_context_query alloca usage
Date: Wed, 20 Sep 2023 12:09:38 +0200	[thread overview]
Message-ID: <dd5112d0-b244-4787-a5e8-1a976347b3fd@linaro.org> (raw)
In-Reply-To: <87jzss1off.fsf@oldenburg3.str.redhat.com>



On 14/09/23 17:37, Florian Weimer wrote:
> * Adhemerval Zanella:
> 
>> @@ -146,20 +150,20 @@ __res_context_query (struct resolv_context *ctx, const char *name,
>>  		/* Align the buffer.  */
>>  		int npad = ((nquery1 + __alignof__ (HEADER) - 1)
>>  			    & ~(__alignof__ (HEADER) - 1)) - nquery1;
>> -		if (n > bufsize - npad)
>> +		if (n > buf.length - npad)
>>  		  {
>>  		    n = -1;
>>  		    goto unspec_nomem;
>>  		  }
>>  		int nused = n + npad;
> 
> The alignment code shouldn't be necessary anymore.

Indeed, I will update the patch.

  reply	other threads:[~2023-09-20 10:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14 17:54 Adhemerval Zanella
2023-09-14 20:37 ` Florian Weimer
2023-09-20 10:09   ` Adhemerval Zanella Netto [this message]
2023-09-19 20:15 ` Joe Simmons-Talbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd5112d0-b244-4787-a5e8-1a976347b3fd@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=josimmon@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).