From: Zack Weinberg <zackw@panix.com>
To: libc-alpha@sourceware.org
Cc: Joseph Myers <joseph@codesourcery.com>
Subject: Re: Fix struct sigaltstack namespace (bug 21517)
Date: Sat, 03 Jun 2017 14:15:00 -0000 [thread overview]
Message-ID: <dd74f427-29bb-c77f-bab2-477a14733852@panix.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1705242232210.9182@digraph.polyomino.org.uk>
On 05/24/2017 06:32 PM, Joseph Myers wrote:
> glibc defines the stack_t type with the tag struct sigaltstack. This
> is not permitted by POSIX; sigaltstack is only reserved with file
> scope in the namespace of ordinary identifiers, not the tag namespace,
> and in the case where stack_t is obtained from ucontext.h rather than
> signal.h, it's not reserved with file scope at all.
>
> This patch removes the tag accordingly and updates uses in glibc of
> struct sigaltstack. This is similar to the removal of the "struct
> siginfo" tag a few years ago: C++ name mangling changes are an
> unavoidable consequence. A NEWS item is added to note the changed
> mangling. There is inevitably some risk of breaking builds of
> anything that relies on the struct sigaltstack name (though the first
> few hits I looked at from codesearch.debian.net generally seemed to
> involve code that could use the stack_t name conditionally, so
> depending on how they determine the conditionals they may work with
> glibc not defining the struct tag anyway).
I'm not super happy about changing C++ name mangling, but this
particular type is used rarely enough that I think we can get away with
it. Since no one has objected in over a week, this is OK.
zw
next prev parent reply other threads:[~2017-06-03 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 22:33 Joseph Myers
2017-06-01 11:37 ` Ping " Joseph Myers
2017-06-03 14:15 ` Zack Weinberg [this message]
2017-06-03 15:55 ` Florian Weimer
2017-06-12 21:15 ` Khem Raj
2017-06-13 6:34 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd74f427-29bb-c77f-bab2-477a14733852@panix.com \
--to=zackw@panix.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).