From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: [PATCH 2/2] nss: Use shared prefix in IPv4 address in tst-reload1
Date: Fri, 23 Sep 2022 13:13:18 +0200 [thread overview]
Message-ID: <dd8d1a60722612e363ebcfe69d2b1affedda41cf.1663931559.git.fweimer@redhat.com> (raw)
In-Reply-To: <0e287934ef500ec39ac8610dde04f2ea4a9d4010.1663931559.git.fweimer@redhat.com>
Otherwise, sorting based on the longest-matching prefix in
getaddrinfo can reorder the addresses in ways the test does not
expect, depending on the IPv4 address of the host.
---
nss/tst-reload1.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/nss/tst-reload1.c b/nss/tst-reload1.c
index 9cc6115c96..c9db197d55 100644
--- a/nss/tst-reload1.c
+++ b/nss/tst-reload1.c
@@ -43,12 +43,12 @@ static struct passwd pwd_table_1[] = {
static const char *hostaddr_5[] =
{
- "ABCD", "abcd", "1234", NULL
+ "ABCd", "ABCD", "ABC4", NULL
};
static const char *hostaddr_15[] =
{
- "4321", "ghij", NULL
+ "4321", "4322", NULL
};
static const char *hostaddr_25[] =
@@ -86,12 +86,12 @@ static const char *hostaddr_6[] =
static const char *hostaddr_16[] =
{
- "7890", "a1b2", NULL
+ "7890", "7891", NULL
};
static const char *hostaddr_26[] =
{
- "qwer", "tyui", NULL
+ "qwer", "qweR", NULL
};
static struct hostent host_table_2[] = {
--
2.37.3
next prev parent reply other threads:[~2022-09-23 11:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 11:13 [PATCH 1/2] nss: Enhance tst-reload1 coverage and logging Florian Weimer
2022-09-23 11:13 ` Florian Weimer [this message]
2022-09-23 13:34 ` [PATCH 2/2] nss: Use shared prefix in IPv4 address in tst-reload1 Siddhesh Poyarekar
2022-09-23 13:33 ` [PATCH 1/2] nss: Enhance tst-reload1 coverage and logging Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd8d1a60722612e363ebcfe69d2b1affedda41cf.1663931559.git.fweimer@redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).