From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from quail.birch.relay.mailchannels.net (quail.birch.relay.mailchannels.net [23.83.209.151]) by sourceware.org (Postfix) with ESMTPS id 216323858C3A for ; Sat, 22 Jan 2022 03:48:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 216323858C3A X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E77FC6C121B; Sat, 22 Jan 2022 03:47:59 +0000 (UTC) Received: from pdx1-sub0-mail-a304.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 8E3506C1179; Sat, 22 Jan 2022 03:47:59 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a304.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.126.0.25 (trex/6.4.3); Sat, 22 Jan 2022 03:47:59 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Plucky-Spicy: 5d0ecda016430ec6_1642823279815_1969737924 X-MC-Loop-Signature: 1642823279815:4179395301 X-MC-Ingress-Time: 1642823279815 Received: from [192.168.1.174] (unknown [1.186.224.214]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a304.dreamhost.com (Postfix) with ESMTPSA id 4JghzK4bK5z1K3; Fri, 21 Jan 2022 19:47:57 -0800 (PST) Message-ID: Date: Sat, 22 Jan 2022 09:17:52 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 2/3] realpath: Set errno to ENAMETOOLONG for result larger than PATH_MAX [BZ #28770] Content-Language: en-US To: Joseph Myers Cc: libc-alpha@sourceware.org, fweimer@redhat.com References: <20220119082147.3352868-1-siddhesh@sourceware.org> <20220120093252.1911498-1-siddhesh@sourceware.org> <20220120093252.1911498-3-siddhesh@sourceware.org> From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3493.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Jan 2022 03:48:02 -0000 On 22/01/2022 04:52, Joseph Myers wrote: > On Thu, 20 Jan 2022, Siddhesh Poyarekar via Libc-alpha wrote: > >> diff --git a/stdlib/tst-realpath-toolong.c b/stdlib/tst-realpath-toolong.c > >> + char buf[PATH_MAX + 1]; > > This has broken the testsuite build for Hurd. > > tst-realpath-toolong.c: In function 'do_test': > tst-realpath-toolong.c:37:12: error: 'PATH_MAX' undeclared (first use in this function) > Sorry I missed that, I'll post a fix. I was getting a different build error on hurd which prevented me from seeing this. I'm rebuilding my build-many-glibcs to see if that fixes it. Thanks, Siddhesh