From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] io/lockf: Include bits/types.h before __OFF_T_MATCHES_OFF64_T check
Date: Wed, 26 Aug 2020 13:21:32 -0300 [thread overview]
Message-ID: <de404840-0e51-eb67-911b-bc106efcfda3@linaro.org> (raw)
In-Reply-To: <20200826153753.1649367-1-alistair.francis@wdc.com>
On 26/08/2020 12:37, Alistair Francis via Libc-alpha wrote:
> It's possible that although __OFF_T_MATCHES_OFF64_T is defined the
> included the relevent header file. This results in a io/tst-lockf
> failure for RV32 by calling the non 64-bit version of lockf. This
> patch fixes the failure by including bits/types.h.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
We don't use DCO, but rather Copyright assignment.
LGTM, thanks.
As a side note, I think it would be good to move __OFF_T_MATCHES_OFF64_T to be
*always* defined. It would get this issue early.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> io/lockf.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/io/lockf.c b/io/lockf.c
> index aa5c673c8d..8ea83e15f0 100644
> --- a/io/lockf.c
> +++ b/io/lockf.c
> @@ -15,6 +15,8 @@
> License along with the GNU C Library; if not, see
> <https://www.gnu.org/licenses/>. */
>
> +#include <bits/types.h>
> +
> #ifndef __OFF_T_MATCHES_OFF64_T
>
> #include <unistd.h>
>
prev parent reply other threads:[~2020-08-26 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 15:37 Alistair Francis
2020-08-26 16:21 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de404840-0e51-eb67-911b-bc106efcfda3@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).