From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp67.iad3a.emailsrvr.com (smtp67.iad3a.emailsrvr.com [173.203.187.67]) by sourceware.org (Postfix) with ESMTPS id 4E3CC3858C51 for ; Mon, 16 May 2022 16:04:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4E3CC3858C51 X-Auth-ID: tom@honermann.net Received: by smtp9.relay.iad3a.emailsrvr.com (Authenticated sender: tom-AT-honermann.net) with ESMTPSA id 1B5C556EC for ; Mon, 16 May 2022 12:04:45 -0400 (EDT) Message-ID: Date: Mon, 16 May 2022 12:04:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 0/3]: C++20 P0482R6 and C2X N2653: support for char8_t, mbrtoc8(), and c8rtomb(). Content-Language: en-US To: libc-alpha References: <6dd08707-44b9-7c71-29c0-1a072d1e39a3@honermann.net> From: Tom Honermann In-Reply-To: <6dd08707-44b9-7c71-29c0-1a072d1e39a3@honermann.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Classification-ID: a1fdd356-37f4-473a-b99d-bd5c5b368cae-1-1 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2022 16:04:52 -0000 Ping. Could someone please assist me in landing these changes? Tom. On 3/23/22 11:32 AM, Tom Honermann via Libc-alpha wrote: > Is there anything I can do to help land this patch series? I believe > all review comments have been addressed. > > Tom. > > On 2/27/22 11:53 AM, Tom Honermann via Libc-alpha wrote: >> This series of patches provides the following: >> - A fix for bug 25744 [1]. >> - Implementations of the mbrtoc8 and c8rtomb functions adopted for >>   C++20 via WG21 P0482R6 [2] and for C2X via WG14 N2653 [3]. >> - A char8_t typedef as adopted for C2X via WG14 N2653 [3]. >> >> These patches addresses feedback provided in response to a previous >> submission [4]. >> >> Patch 1: A fix and test for bug 25744 [1]. >> Patch 2: Definitions of the mbrtoc8 and c8rtomb functions and the >>          char8_t typedef. >> Patch 3: Tests for the mbrtoc8 and c8rtomb functions and the char8_t >>          typedef. >> >> The fix for bug 25744 [1] is included in this patch series because >> the tests for mbrtoc8 and c8rtomb depend on it for exercising the >> special case where a pair of Unicode code points is converted to/from >> a single double byte sequence. Such conversion cases exist for >> Big5-HKSCS. >> >> N2653 was adopted by WG14 for C2X during their recent meeting. This >> patch series enables the new declarations in C2X mode and when >> _GNU_SOURCE is defined. >> >> Thank you to Joseph Myers and Carlos O'Donell for their prior reviews >> of this patch series. >> >> Tom. >> >> [1]: Bug 25744 >>      "mbrtowc with Big5-HKSCS returns 2 instead of 1 when consuming the >>      second byte of certain double byte characters" >>      https://sourceware.org/bugzilla/show_bug.cgi?id=25744 >> >> [2]: WG21 P0482R6 >>      "char8_t: A type for UTF-8 characters and strings (Revision 6)" >>      https://wg21.link/p0482r6 >> >> [3]: WG14 N2653 >>      "char8_t: A type for UTF-8 characters and strings (Revision 1)" >>      http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2653.htm >> >> [4]: "[PATCH 2/3]: C++20 P0482R6 and C2X N2653: Implement mbrtoc8, >>      c8rtomb, char8_t" >> https://sourceware.org/pipermail/libc-alpha/2022-February/136558.html