From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110617 invoked by alias); 19 Jul 2017 07:10:11 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 110577 invoked by uid 89); 19 Jul 2017 07:10:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_NEUTRAL autolearn=no version=3.3.2 spammy=Poyarekar, poyarekar, reckon X-HELO: homiemail-a52.g.dreamhost.com Subject: Re: libc-2.25.90.pot From: Siddhesh Poyarekar To: Benno Schulenberg , "libc-alpha@sourceware.org" Reply-To: siddhesh@sourceware.org, siddhesh@sourceware.org References: <8b9b4e60-f580-e56a-26bc-adb7192ba779@sourceware.org> <6e7f7602-3536-2edb-0cf4-e66a948fdb71@translationproject.org> <0961b9b1-b6b9-c0c9-bfe3-929ce522d7a8@sourceware.org> Message-ID: Date: Wed, 19 Jul 2017 07:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <0961b9b1-b6b9-c0c9-bfe3-929ce522d7a8@sourceware.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-07/txt/msg00665.txt.bz2 Looping libc-alpha into the response as well; I just noticed that you pinged here too. Siddhesh On Wednesday 19 July 2017 12:38 PM, Siddhesh Poyarekar wrote: > On Monday 17 July 2017 01:31 AM, Benno Schulenberg wrote: >> I see these changes when compared to the previous POT file: >> >> -msgid "\"%s\", line %d: " >> +msgid "\"%s\", line %" >> >> -msgid " (rule from \"%s\", line %d)" >> +msgid " (rule from \"%s\", line %" >> >> Are you sure these changes are intentional? If yes, then maybe >> they could use a translator hint, to say what is coming after the >> last "%"? Also, since those strings are not marked as c-format, >> a malicious translator might be able to crash the relevant program >> by putting in %tralala or something instead of %s? > > It is a safe and intentional change; the full string is: > > "\"%s\", line %"PRIdLINENO": " > > where PRIdLINENO is PRIdMAX, which is a signed integer of maximum width, > which could change for different architectures. It is however a numeric > type. > > Would you like me to add a comment on top of that line to indicate that > it is a numeric type? I reckon the string itself is self-explanatory. > > Siddhesh >