From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id F28AE3858D33 for ; Tue, 10 Jan 2023 22:54:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F28AE3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673391263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R+0w0eLMxGyPYDnksxPvhLgs/cHsXZQ4MT5GbbvZOyE=; b=T2V9GpQc0iJO9OOSXJ1hVE8q0lk58uqempZva3PId6JHeMpBxb63cbCZ9FgKdFWEcjsmfB 4Gorrq1I48SaaL22NUC8CQg/OiUnNeoGuSHhbtdoOHn7lYBVld8dQh/iFRRcKyWiTIm34F +uPsyO/BbIpN81e52kQx80C9BKjJm3I= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-487-V3O0VwkDPT60crF-mHlcmw-1; Tue, 10 Jan 2023 17:54:22 -0500 X-MC-Unique: V3O0VwkDPT60crF-mHlcmw-1 Received: by mail-il1-f197.google.com with SMTP id z19-20020a921a53000000b0030b90211df1so9430713ill.2 for ; Tue, 10 Jan 2023 14:54:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R+0w0eLMxGyPYDnksxPvhLgs/cHsXZQ4MT5GbbvZOyE=; b=rqXe3B6pIB+JjeK7yZc2GK1gxbiAd1c08kcypmzXiVRSHu9UONoWVF7/FY/yt4WkI1 kDWgQSb0dr+ya2kzpx325/MCsUnbqAp0fdikl+xhg879JeuW6TrZZGylFIBaVuvGZL59 3EurRaYff9pmlOjF2JIawaYEVC+Hbd0lugJGi2gB/0sqVYqQTzGMYKTAxo6syC0awIo5 lsrdk3vZExnrIBLE2B2qTYxqcZlA5sa6kKPyE6FqFWfb4NoyES4sCLBRWJbVw5msf0e6 rgfdP4dqB0hvNoJYyia//gneE3tRT9zQL/e5iQFmBfjhgYo7dI84Ham4lhJ3Ajr2OmHj KaAg== X-Gm-Message-State: AFqh2kqhT/hcZxzTI/pVPxup9DGL5vuKCdhNWZ6O76g/y7Yt71jq88nu xdayZlzfdBDb5mk1EvbQ7FdGcnTTKeGn2pxb8Sgla6xAj3XOMAV+LwFUVxqHgUlpeQ5gJ27WMez tz0YQGz/gC+8mtt1N9qad X-Received: by 2002:a92:dc8d:0:b0:30c:4c54:87f4 with SMTP id c13-20020a92dc8d000000b0030c4c5487f4mr22823022iln.3.1673391262073; Tue, 10 Jan 2023 14:54:22 -0800 (PST) X-Google-Smtp-Source: AMrXdXsmk+MjSH8yluzsOfowUd5eRuH5iRVjtUqU/d+NfKETs7QS7OC6le6yFMO8T6zxEZuGTfCVSw== X-Received: by 2002:a92:dc8d:0:b0:30c:4c54:87f4 with SMTP id c13-20020a92dc8d000000b0030c4c5487f4mr22823012iln.3.1673391261843; Tue, 10 Jan 2023 14:54:21 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id r30-20020a02b11e000000b0038acb89a7a6sm4078856jah.28.2023.01.10.14.54.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jan 2023 14:54:20 -0800 (PST) Message-ID: Date: Tue, 10 Jan 2023 17:54:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 4/4] math: Suppress -O0 warnings for soft-fp fsqrt [BZ #19444] To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20221229125802.2715435-1-adhemerval.zanella@linaro.org> <20221229125802.2715435-5-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20221229125802.2715435-5-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/29/22 07:58, Adhemerval Zanella via Libc-alpha wrote: > The patch suppress the same warnings from 87c266d758d29e52bfb717f90, > that shows issues for microblaze, mips soft-fp, nios2, and or1k. LGTM. Reviewed-by: Carlos O'Donell > --- > sysdeps/ieee754/soft-fp/s_fsqrt.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/sysdeps/ieee754/soft-fp/s_fsqrt.c b/sysdeps/ieee754/soft-fp/s_fsqrt.c > index ef631bc6c2..d5c7904118 100644 > --- a/sysdeps/ieee754/soft-fp/s_fsqrt.c > +++ b/sysdeps/ieee754/soft-fp/s_fsqrt.c > @@ -25,6 +25,15 @@ > #undef fsqrtl > > #include > +#include > +/* R_f[01] are not set in cases where they are not used in packing, > + but the compiler does not see that they are set in all cases where > + they are used, resulting in warnings that they may be used > + uninitialized. The location of the warning differs in different > + versions of GCC, it may be where R is defined using a macro or it > + may be where the macro is defined. This happens only with -O1. */ > +DIAG_PUSH_NEEDS_COMMENT; > +DIAG_IGNORE_NEEDS_COMMENT (8, "-Wmaybe-uninitialized"); OK. Agreed, R's usage in _FP_SQRT is conditional. > #include > #include > #include > @@ -51,4 +60,6 @@ __fsqrt (double x) > CHECK_NARROW_SQRT (ret, x); > return ret; > } > +DIAG_POP_NEEDS_COMMENT; > + > libm_alias_float_double (sqrt) -- Cheers, Carlos.