From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp89.iad3b.emailsrvr.com (smtp89.iad3b.emailsrvr.com [146.20.161.89]) by sourceware.org (Postfix) with ESMTPS id 1CF46385BF83 for ; Tue, 14 Apr 2020 19:03:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1CF46385BF83 X-Auth-ID: tom@honermann.net Received: by smtp20.relay.iad3b.emailsrvr.com (Authenticated sender: tom-AT-honermann.net) with ESMTPSA id 541B0A00FB; Tue, 14 Apr 2020 15:03:18 -0400 (EDT) X-Sender-Id: tom@honermann.net Received: from [192.168.1.13] (pool-74-110-208-227.rcmdva.fios.verizon.net [74.110.208.227]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA) by 0.0.0.0:25 (trex/5.7.12); Tue, 14 Apr 2020 15:03:18 -0400 Subject: Re: [PATCH v2] Reset converter state after second wchar_t output (Bug 25734) To: Carlos O'Donell , Andreas Schwab , libc-alpha , Rafal Luzynski References: <691be68d-2969-1076-75a9-4185c5de5f69@honermann.net> <2adea89a-2dca-caf0-db87-08dd1aefe670@honermann.net> <6c3ea93f-4031-6ec1-e19d-cb0d79158b82@redhat.com> From: Tom Honermann Message-ID: Date: Tue, 14 Apr 2020 15:03:17 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <6c3ea93f-4031-6ec1-e19d-cb0d79158b82@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Classification-ID: 5840e770-038a-40b4-9576-da35b6d6c593-1-1 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 19:03:21 -0000 On 4/4/20 2:41 PM, Carlos O'Donell via Libc-alpha wrote: > v2 > - Add test dependency on locale. > - Make test use generic converter dependency (builds all converters) > - Move Rules inclusion to after locale generation to match localedata/ order. > > No regressions on x86_64 and i686. > > I'll push this next week unless someone objects. Hi, Carlos.  Do you have an update on pushing this? I sent a patch [1] for bug 25744 that depends on your changes. Do you have any concerns to share with that patch?  If not, could you please commit it along with your changes for bug 25734? Tom. [1]: https://sourceware.org/pipermail/libc-alpha/2020-April/112595.html