From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fish.tulip.relay.mailchannels.net (fish.tulip.relay.mailchannels.net [23.83.218.251]) by sourceware.org (Postfix) with ESMTPS id 59D403856272 for ; Thu, 5 May 2022 12:26:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 59D403856272 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B3BFEC0B5D; Thu, 5 May 2022 12:26:10 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id F41DEC0F53; Thu, 5 May 2022 12:26:09 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1651753570; a=rsa-sha256; cv=none; b=gNiRkgZqhcIo3WbBeb+m7CNSaA55/uvaLWeVmHYFYgqVrYhVCfzXlqPpF0tN6EfcZzDTH6 8CpF6oaMvrUkj4FOWMbdkpW4ltXL+cRI3FRU1gl4ZKsD7EPI0PxSo6X8s0dvORIAZkXNYt GGlmHO/ckumbNmP0UN1Xwq1pwSvITZ7ZvDrBT23sRlnkMhvxWBxuPeczT+HW6u7qKdLORj I953zGNpuf756/g5vqCj0fQXLilKFXZ3A3K+ZktaNXwOhp7VCFekmoSWbeVIadT8kQqkHG jWjkh3mXLqIJ/YNzY9RbwS+9cDonAt0iTWHMpFIoS7GVvdK2XyEQFimrG2ZjRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1651753570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KmdfM3K0wDKEKHGqanvMn6IWFpmqlF53RKWVzM8A8mw=; b=VYqUFi5rzesqEQTUr6yI0jAcwyi2j8uEnNEm+l3GKfMcXnMp975ImTYfRetop5lZFvBIV+ Xa2QmNVa22hIpsDHEsjhXWBQs+Ctjb7yrGcx2/FHwE5da8XMTTUSPoYZPDxi18TDKxBAn5 sh+4YE/YVC6jCvmuoiaBLXm2urZWsuqGg60CBaTrcv2qcnRa5vaS8ZN7bLJ0f/S4NNsmdy PHEhFwP15Cd4p+oxLPLE/BJ9lx7744sssZxm4UH/pVPNgvuQSSy3USHy/Za9syieJu3Zqb HLqGg7pJ4Pm1SgoUOQwCVC3X4mM8plcyIL+8aXSTgMmdNzhIn6cVhy36Sc/B3g== ARC-Authentication-Results: i=1; rspamd-847dd8955c-4knsj; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Versed-Madly: 0e817d8b5aa3f708_1651753570565_927247146 X-MC-Loop-Signature: 1651753570565:3721049926 X-MC-Ingress-Time: 1651753570565 Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.106.158.137 (trex/6.7.1); Thu, 05 May 2022 12:26:10 +0000 Received: from [192.168.1.174] (unknown [1.186.223.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4KvCbd5mw5znZ; Thu, 5 May 2022 05:26:05 -0700 (PDT) Message-ID: Date: Thu, 5 May 2022 17:56:00 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 4/4] clock_settime/clock_gettime: Use __nonnull to avoid null pointer Content-Language: en-US To: Xiaoming Ni , drepper@redhat.com, lukma@denx.de, adrian.ratiu@collabora.com, schwab@linux-m68k.org, fweimer@redhat.com, adhemerval.zanella@linaro.org Cc: wangle6@huawei.com, libc-alpha@sourceware.org References: <20220428122529.108208-1-nixiaoming@huawei.com> <20220505030111.111197-1-nixiaoming@huawei.com> <20220505030111.111197-5-nixiaoming@huawei.com> From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3488.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2022 12:26:16 -0000 On 05/05/2022 13:53, Xiaoming Ni via Libc-alpha wrote: > On 2022/5/5 12:26, Siddhesh Poyarekar wrote: >> On 05/05/2022 08:31, Xiaoming Ni via Libc-alpha wrote: >>> clock_settime() >>> clock_settime64() >>> clock_gettime() >>> clock_gettime64() >>> Add __nonnull((2)) to avoid null pointer access. >>> >>> Link: https://sourceware.org/bugzilla/show_bug.cgi?id=27662 >>> Link: https://sourceware.org/bugzilla/show_bug.cgi?id=29084 >>> Signed-off-by: Xiaoming Ni >>> --- >> >> LGTM. >> >> Reviewed-by: Siddhesh Poyarekar >> >> Do you have commit access or do you need someone to push this for you? >> >> Thanks, >> Siddhesh >> >> . > I don't have the permission to push directly. > Can you help push this patch set? Done, thanks. Siddhesh