From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id 07763385E45A for ; Mon, 21 Feb 2022 18:07:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 07763385E45A Received: by mail-oi1-x22a.google.com with SMTP id ay7so11712455oib.8 for ; Mon, 21 Feb 2022 10:07:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Tub2RyCDG5MPFmLhV0vv1h0olijV15zDpWYMFibe8nc=; b=Impy9iSqdPw94v/+Y+Hc4cBDPiWZ25UGfpyNKubaTM7nnoWvMR/HcQebWebPhibC5R uJvyXRfQ7Wgp8JLLWF+8IvHbPdJ1/hURtzklMiYnDckbsgLwUMBKDTu1+WtGkXy/ZYmN yZOM3Rd97mIRLSe8p8YAvBwrYyTZRqGv5jMF725qm1s9H3BNvCJSTMqBgg6OXaFThGP5 vioM0/aommT++JMw7vQ+KHLnLHpUDS8qCURSho6JQt/oqvTYq5/qCTCoy2kbe1ccn3W7 4ilPaebWLRdhNqnTg6M3KSvqI2kGoL0AgHwaB8W0dccjcIVf5qwTAhDLlrurovZ7WE77 ojug== X-Gm-Message-State: AOAM530FfRV9Z6pqTdS8EzsM4VFZe8WnXrhSNMYgYmTyAywEUASVP0w5 HIVCLd6UTP/2Nxx42z8dtOdSAnWkFAhTbg== X-Google-Smtp-Source: ABdhPJxDxJTxt4x4IHJi8c3DhJ3qe9Ys4WO+mnCg4r7s+0NSWtCtTSAWU4/IUziF1aVwZwouQKK61A== X-Received: by 2002:aca:b688:0:b0:2d3:5411:9bc0 with SMTP id g130-20020acab688000000b002d354119bc0mr128769oif.192.1645466853405; Mon, 21 Feb 2022 10:07:33 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:cb36:ae42:babb:bfa3:4f13? ([2804:431:c7ca:cb36:ae42:babb:bfa3:4f13]) by smtp.gmail.com with ESMTPSA id z28sm2062402oti.5.2022.02.21.10.07.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 10:07:32 -0800 (PST) Message-ID: Date: Mon, 21 Feb 2022 15:07:30 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] or1k: Define PI_STATIC_AND_HIDDEN Content-Language: en-US To: Stafford Horne , GLIBC patches Cc: Openrisc , Florian Weimer References: <20220128232842.3329969-1-shorne@gmail.com> From: Adhemerval Zanella In-Reply-To: <20220128232842.3329969-1-shorne@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2022 18:07:35 -0000 On 28/01/2022 20:28, Stafford Horne wrote: > PI_STATIC_AND_HIDDEN means that references to static functions, data > and symbols with hidden visibility do not need any run-time relocations > after the final link, with the build flags used by glibc. > > OpenRISC follows this so enabled PI_STATIC_AND_HIDDEN by adding > configure.ac and generating configure. > > Suggested-by: Florian Weimer LGTM, thanks. Stafford, you are the or1k maintainer and most likely the one with a setup to actually test it. For such arch specific changes, you can push it without require other maintainer ack. > --- > This was discussed on the mailing list: > https://sourceware.org/pipermail/libc-alpha/2022-January/135620.html > > I thought to get this out as I start to test 2.35 we want this change in. > > sysdeps/or1k/configure | 5 +++++ > sysdeps/or1k/configure.ac | 4 ++++ > 2 files changed, 9 insertions(+) > create mode 100644 sysdeps/or1k/configure > create mode 100644 sysdeps/or1k/configure.ac > > diff --git a/sysdeps/or1k/configure b/sysdeps/or1k/configure > new file mode 100644 > index 0000000000..d73db4ddbe > --- /dev/null > +++ b/sysdeps/or1k/configure > @@ -0,0 +1,5 @@ > +# This file is generated from configure.ac by Autoconf. DO NOT EDIT! > + # Local configure fragment for sysdeps/or1k/elf. > + > +$as_echo "#define PI_STATIC_AND_HIDDEN 1" >>confdefs.h > + > diff --git a/sysdeps/or1k/configure.ac b/sysdeps/or1k/configure.ac > new file mode 100644 > index 0000000000..db6a6087e1 > --- /dev/null > +++ b/sysdeps/or1k/configure.ac > @@ -0,0 +1,4 @@ > +GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory. > +# Local configure fragment for sysdeps/or1k/elf. > + > +AC_DEFINE(PI_STATIC_AND_HIDDEN)