* [PATCH] benchtests: Updated json bench-variant attribute
@ 2021-02-08 7:59 Naohiro Tamura
2021-02-08 14:09 ` Siddhesh Poyarekar
0 siblings, 1 reply; 3+ messages in thread
From: Naohiro Tamura @ 2021-02-08 7:59 UTC (permalink / raw)
To: libc-alpha
This patch updates json "bench-variant" attribute of "bench-memset.c"
to "default" so that the script "benchtests/scripts/plot_strings.py"
can generate a file "memset_time_default_linear.png".
Without this patch, the script "benchtests/scripts/plot_strings.py"
generates a file "memset_time__linear.png" which has inconsistent form
with "memcpy_time_default_linear.png" and
"memmove_time_default_linear.png".
---
benchtests/bench-memset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/benchtests/bench-memset.c b/benchtests/bench-memset.c
index a84e781bdb..1174900e88 100644
--- a/benchtests/bench-memset.c
+++ b/benchtests/bench-memset.c
@@ -97,7 +97,7 @@ test_main (void)
json_attr_object_begin (&json_ctx, "functions");
json_attr_object_begin (&json_ctx, TEST_NAME);
- json_attr_string (&json_ctx, "bench-variant", "");
+ json_attr_string (&json_ctx, "bench-variant", "default");
json_array_begin (&json_ctx, "ifuncs");
FOR_EACH_IMPL (impl, 0)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] benchtests: Updated json bench-variant attribute
2021-02-08 7:59 [PATCH] benchtests: Updated json bench-variant attribute Naohiro Tamura
@ 2021-02-08 14:09 ` Siddhesh Poyarekar
2021-02-09 0:33 ` naohirot
0 siblings, 1 reply; 3+ messages in thread
From: Siddhesh Poyarekar @ 2021-02-08 14:09 UTC (permalink / raw)
To: Naohiro Tamura, libc-alpha
On 2/8/21 1:29 PM, Naohiro Tamura wrote:
> This patch updates json "bench-variant" attribute of "bench-memset.c"
> to "default" so that the script "benchtests/scripts/plot_strings.py"
> can generate a file "memset_time_default_linear.png".
> Without this patch, the script "benchtests/scripts/plot_strings.py"
> generates a file "memset_time__linear.png" which has inconsistent form
> with "memcpy_time_default_linear.png" and
> "memmove_time_default_linear.png".
That's nicer, I agree. Looks good to me, I'll commit it if you don't
have access.
Siddhesh
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] benchtests: Updated json bench-variant attribute
2021-02-08 14:09 ` Siddhesh Poyarekar
@ 2021-02-09 0:33 ` naohirot
0 siblings, 0 replies; 3+ messages in thread
From: naohirot @ 2021-02-09 0:33 UTC (permalink / raw)
To: 'Siddhesh Poyarekar', libc-alpha
Siddhesh-san,
> -----Original Message-----
> From: Siddhesh Poyarekar <siddhesh@gotplt.org>
> Sent: Monday, February 8, 2021 11:09 PM
> To: Tamura, Naohiro/田村 直広 <naohirot@fujitsu.com>;
> libc-alpha@sourceware.org
> Subject: Re: [PATCH] benchtests: Updated json bench-variant attribute
>
> On 2/8/21 1:29 PM, Naohiro Tamura wrote:
> > This patch updates json "bench-variant" attribute of "bench-memset.c"
> > to "default" so that the script "benchtests/scripts/plot_strings.py"
> > can generate a file "memset_time_default_linear.png".
> > Without this patch, the script "benchtests/scripts/plot_strings.py"
> > generates a file "memset_time__linear.png" which has inconsistent form
> > with "memcpy_time_default_linear.png" and
> > "memmove_time_default_linear.png".
>
> That's nicer, I agree. Looks good to me, I'll commit it if you don't have access.
Thank you for reviewing quickly.
Yes, please, I don't have the access. I appreciate that!
Naohiro
> Siddhesh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-09 0:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-08 7:59 [PATCH] benchtests: Updated json bench-variant attribute Naohiro Tamura
2021-02-08 14:09 ` Siddhesh Poyarekar
2021-02-09 0:33 ` naohirot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).