From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from donkey.ash.relay.mailchannels.net (donkey.ash.relay.mailchannels.net [23.83.222.49]) by sourceware.org (Postfix) with ESMTPS id 543543854821 for ; Mon, 8 Feb 2021 14:09:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 543543854821 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 612967837EF; Mon, 8 Feb 2021 14:09:17 +0000 (UTC) Received: from pdx1-sub0-mail-a51.g.dreamhost.com (100-96-17-21.trex.outbound.svc.cluster.local [100.96.17.21]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E74D7783888; Mon, 8 Feb 2021 14:09:16 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a51.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.17.21 (trex/6.0.2); Mon, 08 Feb 2021 14:09:17 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Bored-Juvenile: 73210d452bd38818_1612793357177_2746645728 X-MC-Loop-Signature: 1612793357177:3730910381 X-MC-Ingress-Time: 1612793357177 Received: from pdx1-sub0-mail-a51.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a51.g.dreamhost.com (Postfix) with ESMTP id A18F47F3AF; Mon, 8 Feb 2021 06:09:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=oymq42 0WJjo7xJKbng4FTietM7Y=; b=vgYWwuru5a0IUeSdTQnhqboKrsIR5AZNGAtvdM Hv46fScN9k7HTCaVqNHgoA+5CSuStdSv8TkOK64o6OxZIOoK8aY48RPDf6vJ6q51 GpOzNTHyifIvKzvfLDRsXQay7F5ifiM/EXB062j5SEYZFJWYQIcuuP6c75WhXwQY baAkg= Received: from [192.168.1.111] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a51.g.dreamhost.com (Postfix) with ESMTPSA id E36787F3AA; Mon, 8 Feb 2021 06:09:14 -0800 (PST) Subject: Re: [PATCH] benchtests: Updated json bench-variant attribute To: Naohiro Tamura , libc-alpha@sourceware.org References: <20210208075953.48422-1-naohirot@fujitsu.com> X-DH-BACKEND: pdx1-sub0-mail-a51 From: Siddhesh Poyarekar Message-ID: Date: Mon, 8 Feb 2021 19:39:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210208075953.48422-1-naohirot@fujitsu.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3030.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2021 14:09:23 -0000 On 2/8/21 1:29 PM, Naohiro Tamura wrote: > This patch updates json "bench-variant" attribute of "bench-memset.c" > to "default" so that the script "benchtests/scripts/plot_strings.py" > can generate a file "memset_time_default_linear.png". > Without this patch, the script "benchtests/scripts/plot_strings.py" > generates a file "memset_time__linear.png" which has inconsistent form > with "memcpy_time_default_linear.png" and > "memmove_time_default_linear.png". That's nicer, I agree. Looks good to me, I'll commit it if you don't have access. Siddhesh