From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from caracal.birch.relay.mailchannels.net (caracal.birch.relay.mailchannels.net [23.83.209.30]) by sourceware.org (Postfix) with ESMTPS id 1A87B3858D20 for ; Thu, 25 May 2023 01:53:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A87B3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 48B11200E28; Thu, 25 May 2023 01:53:11 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id BE68A200F1D; Thu, 25 May 2023 01:53:10 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1684979590; a=rsa-sha256; cv=none; b=VqGHLSWTPN1/tMaxi4pYvhyScDFHISlRVU7VwEKxIVPXxPMITNCarsEzjB8oTj4lT9ii0t 7N+Pv6GvaTXXzSLSA1KniJecjTKp8DkbMVV+Q67JZ/NUA9GIqZ19ZzGYH0rz9yXBgDbWeA piU4BhftTsZVnm9bs3DkXWW8zCXqmA3mmdnd2qR8bW7XmajQWG61ditZszeWnmTMg5HSh3 vKbIff49ygsfggLPbwmaN4bLP3Z4BGl6YA6HzZQlCfMcS8ynO0ie9zmqrxSTMZvb2yv79k z6Sk00wdOCiGpmd7Lve6/hu1RoLLHClY91vlhp1xBOBQ5Ei1fKJVremcNBF2sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1684979590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FSu3d6Ufq+a3gNQpG8xbXxm2NJWNU6VRznNqAEi75eE=; b=CE5CtLV/Hakm1wS1dlMUh6AyhkiMSzgVeB+lhGZD0C3Z0ajPp/P+H+OvrR5GeGkL26V52u bUSe0YkL+KkrlR98e/7/pJ3zM324JzoMh58wuOa32lQ/5XYrynnt2kgqV92y6w1+D67zKl mxMvhxNP0I7qu63GwvKjrhpZkn1sL0cgrvIoYJw5pAn25Vt6z7sM5c2p/zptxelYP6tscP rIRi1AjhhTzdLVJkitJFHEnkBIdQAL3ppgVcLL5KXB4TUtub03OPkbNGU0d5LJlh61rxOD qjf/qorszBq5elXzZtXo0ex8ZoyWbvektV+d0GdouuqwCUt6eh2rNAXbuvPFww== ARC-Authentication-Results: i=1; rspamd-79bb5575d7-hbqrk; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Macabre-Print: 44a92b6a6151eaf5_1684979591015_285589200 X-MC-Loop-Signature: 1684979591015:1208708783 X-MC-Ingress-Time: 1684979591015 Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.104.253.217 (trex/6.8.1); Thu, 25 May 2023 01:53:11 +0000 Received: from [192.168.0.182] (bras-vprn-toroon4834w-lp130-02-142-113-138-85.dsl.bell.ca [142.113.138.85]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4QRWKf2CCjzB8; Wed, 24 May 2023 18:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1684979590; bh=FSu3d6Ufq+a3gNQpG8xbXxm2NJWNU6VRznNqAEi75eE=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=FrpH0pNiGMxJoAppDpka3Z0LmfD3m5jFG5a0vqSzWK91KKFb0xnVf2O9QMEvznYnB 7tNVfPIUaCMa4x0AqElFOjObSS/VuZXWR7w5IHl5jnmtd64gEnypv9K7Q+/fI7ZCJF iPmsKiT6nzdKpZMn2ff8sJ4eGQyZVvHV7otKJ2KHCrVNJ0Xbwa19v055wzeqagGVXh ZLfzAQCUjoxEiq5ReBOi6zt2/GhTPg8ZNrKHL2AoNZaQc6QpQnNs/bzT9SRegMAakw swpb0vD9JBi5tvQm43JYwWbGEZ30b1nqDvgRSi8kOUeQApn/ppIJblogwbsJ2f/O73 vgwDDHcw/MocQ== Message-ID: Date: Wed, 24 May 2023 21:53:09 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 00/15] Fix warn unused result Content-Language: en-US To: =?UTF-8?B?RnLDqWTDqXJpYyBCw6lyYXQ=?= , libc-alpha@sourceware.org References: <20230428122142.928135-1-fberat@redhat.com> From: Siddhesh Poyarekar In-Reply-To: <20230428122142.928135-1-fberat@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3031.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-04-28 08:21, Frédéric Bérat wrote: > Hello, > > Enabling _FORTIFY_SOURCE on Glibc itself implies that some function get the > __wur macro enabed. > This leads to build failures when -Werror is set. > > I went for multiple patches for these fixes, a big one that cover the tests, > and then separate one for the other ones, assuming they may need to get a > closer look at. > > While most of the changes look trivial, decision I made on how to fix them may > be open to debate, e.g. the additional checks may lead to failures while they > weren't earlier, some other have no impact while it may be useful to have one. > > Feedback is therefore highly appreciated. Thank you for your continued work on this; 3 down, 12 (and a bit more ;)) to go. I have pushed 3 of the patches I get R-b for. Overall for the remaining patches, there's one review note that's pertinent; the tests that you've added the x* function calls for need to use the support.h system, i.e. replace test-skeleton.c with support/test-driver.c and then replace the non-zero returns from do_test with the check.h macros. Thanks, Sid