From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9226 invoked by alias); 15 Jun 2017 18:46:24 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 9185 invoked by uid 89); 15 Jun 2017 18:46:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f182.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3H9MsFYO5pUPDeiJ7ysRNyWcKnpdpHhiSOrMiUvLSok=; b=Lz8NxX2ZQet4MkiNRJglXHQ2clruVKDflePO/V0Ef44sgh5z6CVudVjXINBrxFwpbs HcbjTdKGh9pXbvgocd9S45WgNXoVFt1FK360mRs4NpemkvXX1V6mZqlmS7jD5+CQYOB2 u633Wc6Ziq8VqFdg21eFjM/VUGTXmWzZCAo6irM9HLZQqUOj+Qon4ekwxwT3uP1Cw7PN IUN9/lll1srJXjhSQ9ZOVvNTMbhyG2DmB4tO3mff7uKEV2QTRvheKIs/69lN0izWJ5NR PX32rj+puk+HhE6hJAr1q3fAvWmh9ZzAJr/QSWmsg0Mt7O4mGMDy0/cGiAayGNAUl0xe /SZg== X-Gm-Message-State: AKS2vOzPzuvmNmxVMpaspYujkfbveZ94ABuIaxIEdwJuztWYgoDLefg5 0kdI584gnw8RVUa88kDfqw== X-Received: by 10.55.215.130 with SMTP id t2mr7936299qkt.188.1497552384214; Thu, 15 Jun 2017 11:46:24 -0700 (PDT) Subject: Re: [PATCH 3/5] linux: Consolidate sync_file_range implementation From: Adhemerval Zanella To: libc-alpha@sourceware.org References: <1495563960-669-1-git-send-email-adhemerval.zanella@linaro.org> <1495563960-669-4-git-send-email-adhemerval.zanella@linaro.org> Message-ID: Date: Thu, 15 Jun 2017 18:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1495563960-669-4-git-send-email-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00687.txt.bz2 On 23/05/2017 15:25, Adhemerval Zanella wrote: > This patch consolidates Linux sync_file_range at default > sysdeps/unix/sysv/linux/sync_file_range.c implementation. It also > moves the rules flags from generic io/Makefile to Linux one due the > fact it is a Linux-only symbol. > > Checked on i686-linux-gnu and x86_64-linux-gnu. > > * io/Makefile (CFLAGS-sync_file_range.c): Remove rule. > * sysdeps/unix/sysv/linux/Makefile (CFLAGS-sync_file_range.c): New > rule. > * sysdeps/unix/sysv/linux/wordsize-64/syscalls.list: Remove > sync_file_range. This patch is straightforward and follow the other consolidation I have done. I will push this soon. > --- > ChangeLog | 6 ++++++ > io/Makefile | 1 - > sysdeps/unix/sysv/linux/Makefile | 1 + > sysdeps/unix/sysv/linux/wordsize-64/syscalls.list | 1 - > 4 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/io/Makefile b/io/Makefile > index 16365e5..2f26bf5 100644 > --- a/io/Makefile > +++ b/io/Makefile > @@ -99,7 +99,6 @@ CFLAGS-posix_fallocate.c = -fexceptions > CFLAGS-posix_fallocate64.c = -fexceptions > CFLAGS-fallocate.c = -fexceptions > CFLAGS-fallocate64.c = -fexceptions > -CFLAGS-sync_file_range.c = -fexceptions > CFLAGS-read.c = -fexceptions > CFLAGS-write.c = -fexceptions > > diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile > index 99b3f9d..1a170c2 100644 > --- a/sysdeps/unix/sysv/linux/Makefile > +++ b/sysdeps/unix/sysv/linux/Makefile > @@ -25,6 +25,7 @@ CFLAGS-tee.c = -fexceptions -fasynchronous-unwind-tables > CFLAGS-vmsplice.c = -fexceptions -fasynchronous-unwind-tables > CFLAGS-splice.c = -fexceptions -fasynchronous-unwind-tables > CFLAGS-open_by_handle_at.c = -fexceptions -fasynchronous-unwind-tables > +CFLAGS-sync_file_range.c = -fexceptions -fasynchronous-unwind-tables > CFLAGS-tst-writev.c += "-DARTIFICIAL_LIMIT=(0x80000000-sysconf(_SC_PAGESIZE))" > > # Note that bits/mman-linux.h is listed here though the file lives in the > diff --git a/sysdeps/unix/sysv/linux/wordsize-64/syscalls.list b/sysdeps/unix/sysv/linux/wordsize-64/syscalls.list > index 5c78677..4bb7ebf 100644 > --- a/sysdeps/unix/sysv/linux/wordsize-64/syscalls.list > +++ b/sysdeps/unix/sysv/linux/wordsize-64/syscalls.list > @@ -4,7 +4,6 @@ fstatfs - fstatfs i:ip __fstatfs fstatfs fstatfs64 __fstatfs64 > statfs - statfs i:sp __statfs statfs statfs64 > readahead - readahead i:iii __readahead readahead > sendfile - sendfile i:iipi sendfile sendfile64 > -sync_file_range - sync_file_range Ci:iiii sync_file_range > prlimit EXTRA prlimit64 i:iipp prlimit prlimit64 > > fanotify_mark EXTRA fanotify_mark i:iiiis fanotify_mark >