From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77870 invoked by alias); 18 Aug 2017 06:51:28 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 77852 invoked by uid 89); 18 Aug 2017 06:51:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=nervous X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH] powerpc: Use aligned stores in memset To: Florian Weimer , libc-alpha@sourceware.org References: <1503033107-20047-1-git-send-email-raji@linux.vnet.ibm.com> From: Rajalakshmi Srinivasaraghavan Date: Fri, 18 Aug 2017 06:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 17081806-0016-0000-0000-00000260DCFF X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17081806-0017-0000-0000-000006E37A83 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-18_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1708180111 X-SW-Source: 2017-08/txt/msg00841.txt.bz2 On 08/18/2017 11:51 AM, Florian Weimer wrote: > On 08/18/2017 07:11 AM, Rajalakshmi Srinivasaraghavan wrote: >> * sysdeps/powerpc/powerpc64/power8/memset.S: Store byte by byte >> for unaligned inputs if size is less than 8. > > This makes me rather nervous. powerpc64le was supposed to have > reasonable efficient unaligned loads and stores. GCC happily generates > them, too. This is meant ONLY for caching inhibited accesses. Caching Inhibited accesses are required to be Guarded and properly aligned. > > Thanks, > Florian > > -- Thanks Rajalakshmi S