From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 7FA1B3858C3A for ; Tue, 11 Jul 2023 16:05:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7FA1B3858C3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36BFqCgR009404; Tue, 11 Jul 2023 16:05:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=aZltmsbdqvwXA3UYzvxgKj44hiWsw6rqOyCW6CfEsiI=; b=mhsmYec5+kjLjwh63Z7RMMNpq0u6HC/sKPRVB0OF4gpqCpIFrhSFStOjzBfix/oEd0v5 1sfHZj/cPOAyMXxQktuBO8qCwrk7gQsERFM3p3DoJ0pv9Rh2t50p4Kf+Og9GbSJ8GLT3 SmFdfOimjo/jApujCJzsfS6jRseMcWYJdm59SeHIZyI521odxlgyutLpyS1k4+mOr51c Q0KHcm65E8qOvAdd9KQbhYQHfYiVYa5Wn79HAzuAGpOif/PXga3wh5qwWAxHP4GXwKJI o0uhildfTgLKHrren4fSQE01J/dtDD/8mOE0J9g/9JexGye1CFef0Z0YUQgbGBtaJJn+ JQ== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rsa3m0ckd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Jul 2023 16:05:22 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 36BEFiYm019772; Tue, 11 Jul 2023 16:05:21 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3rqmu0r6jj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Jul 2023 16:05:21 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 36BG5JTx36307330 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jul 2023 16:05:19 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 43CC25805E; Tue, 11 Jul 2023 16:05:19 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E19425805B; Tue, 11 Jul 2023 16:05:16 +0000 (GMT) Received: from [9.43.112.109] (unknown [9.43.112.109]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 11 Jul 2023 16:05:16 +0000 (GMT) Message-ID: Date: Tue, 11 Jul 2023 21:35:15 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v5] PowerPC: Influence cpu/arch hwcap features via GLIBC_TUNABLES. Content-Language: en-US To: Adhemerval Zanella Netto , Peter Bergner , libc-alpha@sourceware.org Cc: rajis@linux.ibm.com, Mahesh Bodapati References: <20230710182150.2376678-1-bmahi496@linux.ibm.com> <4bc867e2-ce47-c35d-52ed-9b0381b2b44f@linaro.org> From: MAHESH BODAPATI In-Reply-To: <4bc867e2-ce47-c35d-52ed-9b0381b2b44f@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: E3iMBdnuo27yT86yKlTJg_mMtnv9ch4y X-Proofpoint-ORIG-GUID: E3iMBdnuo27yT86yKlTJg_mMtnv9ch4y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-11_08,2023-07-11_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 mlxlogscore=962 suspectscore=0 mlxscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307110144 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/07/23 5:54 pm, Adhemerval Zanella Netto wrote: > > On 10/07/23 18:28, Peter Bergner wrote: >> On 7/10/23 1:21 PM, bmahi496@linux.ibm.com wrote: >>> Note that the tunable only handles the features which are really used >>> in the IFUNC selection. All others are ignored as the values are only >>> used inside glibc. >> I don't understand this comment. Your code seems to handle all hwcap >> features, not just the features used within glibc. That's fine with me, >> because I'd like these changes to eventually be exported to the TCB and >> then we should handle all known features. Maybe the comment just needs >> updating? >> >> >> >> >>> + /* Copy the features from dl_powerpc_cpu_features, which contains the >>> + features provided by AT_HWCAP and AT_HWCAP2. */ >>> + struct cpu_features *cpu_features = &GLRO(dl_powerpc_cpu_features); >> ^ >> Space needed before the '('. > For variable-like access, such as with macro for GL or GLRO, there is no > need for the space. okay. > >> >> >>> + tun_count = sizeof(hwcap_tunables)/sizeof(hwcap_tunables[0]); >> Ditto for both '('s and before and after the '/'. > User array_length macro instead. Thanks. I will use array_length macro.