From: Paul Eggert <eggert@cs.ucla.edu>
To: Florian Weimer <fweimer@redhat.com>,
Carlos O'Donell <carlos@redhat.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] Add renameat2 function [BZ #17662]
Date: Wed, 04 Jul 2018 20:36:00 -0000 [thread overview]
Message-ID: <e0dc7645-8c62-ab37-907e-8ec752d1ea43@cs.ucla.edu> (raw)
In-Reply-To: <c25d33d7-cc6b-0911-222d-0f8741a892da@redhat.com>
Florian Weimer wrote:
>> * The library now implements the renameat2 function. On Linux systems that
>> support the renameat2 system call this is a wrapper for kernel support
>> and when renameat2's flags are nonzero this should avoid race conditions
>> present with renameat. The renameat2 function fails with an errno of
>> ENOSYS or EINVAL when given nonzero flags that cannot be implemented
>> atomically by the kernel.
>
> I don't think the current renameat2 fallback code in glibc can return ENOSYS.
> The generic renameat, which returns ENOSYS, is overriden by Linux and Hurd.
Ah, OK, in that case please remove "ENOSYS or" from the proposed text.
next prev parent reply other threads:[~2018-07-04 20:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-30 12:15 Florian Weimer
2018-06-30 20:22 ` Joseph Myers
2018-06-30 21:11 ` Florian Weimer
2018-06-30 22:26 ` Joseph Myers
2018-07-01 21:49 ` Yury Norov
2018-07-02 6:48 ` Florian Weimer
2018-07-02 8:46 ` Yury Norov
2018-07-02 9:32 ` Florian Weimer
2018-07-02 8:59 ` Andreas Schwab
2018-07-02 15:11 ` Joseph Myers
2018-07-02 17:38 ` Paul Eggert
2018-07-02 19:46 ` Joseph Myers
2018-07-02 19:58 ` Paul Eggert
2018-07-03 6:40 ` Florian Weimer
2018-07-03 19:06 ` Paul Eggert
2018-07-04 9:04 ` Andreas Schwab
2018-07-04 10:39 ` Florian Weimer
2018-07-04 16:31 ` Carlos O'Donell
2018-07-04 19:36 ` Paul Eggert
2018-07-04 20:13 ` Carlos O'Donell
2018-07-04 20:26 ` Florian Weimer
2018-07-04 20:46 ` Paul Eggert
2018-07-05 13:19 ` Carlos O'Donell
2018-07-04 20:47 ` Paul Eggert
2018-07-04 19:21 ` Carlos O'Donell
2018-07-04 19:53 ` Paul Eggert
2018-07-04 20:28 ` Florian Weimer
2018-07-04 20:36 ` Paul Eggert [this message]
2018-07-05 14:01 ` Florian Weimer
2018-07-05 14:25 ` Paul Eggert
2018-07-05 15:26 ` Florian Weimer
2018-07-05 16:53 ` Paul Eggert
2018-07-05 16:57 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0dc7645-8c62-ab37-907e-8ec752d1ea43@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).