From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>, libc-alpha@sourceware.org
Cc: "H . J . Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH 3/3] elf: Enable TLS descriptor tests on aarch64
Date: Mon, 11 Mar 2024 09:36:28 -0300 [thread overview]
Message-ID: <e0eb6fc1-c541-4da1-8f96-c86ea18662e7@linaro.org> (raw)
In-Reply-To: <Ze75ib4MMG4ih66b@arm.com>
On 11/03/24 09:31, Szabolcs Nagy wrote:
> The 02/29/2024 16:46, Adhemerval Zanella wrote:
>> The aarch64 uses a different name than x86 and arm (trad instead
>> os gnu2). Use it to check whether to enable the TLS descriptor
>> tests.
>
> aarch64 uses 'trad' for traditional tls and 'desc' for tls
> descriptors, but unlike other targets it defaults to 'desc'.
>
>>
>> Also rename the internal machinery fron gnu2 to tls descriptors.
>>
>> Checked on aarch64-linux-gnu.
> ...
>> --- a/sysdeps/aarch64/preconfigure
>> +++ b/sysdeps/aarch64/preconfigure
>> @@ -2,5 +2,6 @@ case "$machine" in
>> aarch64*)
>> base_machine=aarch64
>> machine=aarch64
>> + mtls_descriptor=trad
>> ;;
>> esac
>
> i think this is confusing.
>
It is indeed, it should be 'desc' instead of 'trad' here.
> on aarch64 mtls_descriptor should be 'desc', but we might
> want to run some tests with 'trad' too for coverage (however
> likely different tests than what other targets try to run with
> tlsdesc).
>
I will check the machinery required to enable all tls tests for
both modes.
prev parent reply other threads:[~2024-03-11 12:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 19:46 [PATCH 0/3] Extending TLS testing and fixing TLS gnu2 for ARM Adhemerval Zanella
2024-02-29 19:46 ` [PATCH 1/3] Ignore undefined symbols for -mtls-dialect=gnu2 Adhemerval Zanella
2024-03-05 20:07 ` H.J. Lu
2024-03-05 20:17 ` Adhemerval Zanella Netto
2024-03-05 20:22 ` H.J. Lu
2024-02-29 19:46 ` [PATCH 2/3] arm: Update _dl_tlsdesc_dynamic to preserve caller-saved registers (BZ 31372) Adhemerval Zanella
2024-02-29 19:46 ` [PATCH 3/3] elf: Enable TLS descriptor tests on aarch64 Adhemerval Zanella
2024-03-11 12:31 ` Szabolcs Nagy
2024-03-11 12:36 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0eb6fc1-c541-4da1-8f96-c86ea18662e7@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).