From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by sourceware.org (Postfix) with ESMTPS id 2B8A93857C50 for ; Wed, 24 Mar 2021 12:56:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2B8A93857C50 Received: by mail-qk1-x730.google.com with SMTP id y5so16285907qkl.9 for ; Wed, 24 Mar 2021 05:56:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sBaQogiVXbSHi1yx++TyOLpH62DOL5K/a5YtGlmZcWs=; b=L6qo4s8uQi0z6rgc8GQRAetcmyUMF/NRCktQAbHu+heUJxM9ed0d6o1MJC/jflwiMC RzkUBP60nRvIX7YRq4cvJpuU9Mu8dZd/yvGYD56mFrVEIt6IW+Xk3Gwd8xh0RWmbA1iY Bb8GTcpNx5ClHCT3lPqPXewZi8d7pTajAiGCoS4whMPuF4Qm31rspEdIZ7JAdWr8ZQFC SLjHne4QAvE9rPpHnTGZVd56y9pUbLbQ2oPi72Zlple+7JUZoIhKjy/TqoUBoiJ7zsBq DKjPPHyB644CLeoCdsQ1oTpRaJSjUrnWYTgcprbrkte6eM3pGhfasrY0sFUaXZEJW2F9 hwAg== X-Gm-Message-State: AOAM5327SkdoDU/SxWEcgwKlLm+d3Ce/PHl5sbxR6hUE/Eon3wYiDlwo Mkvkz+Rr+JqDDI5q4EU8odGIQpGCItXhvw== X-Google-Smtp-Source: ABdhPJw52g/4BQ2mytpYaFBdKS4kOwRI0iXRyL8yWE4q84WYXkHuabX2bb0rVoSpHvHc7BE4cv29JA== X-Received: by 2002:a05:620a:525:: with SMTP id h5mr2951713qkh.100.1616590609597; Wed, 24 Mar 2021 05:56:49 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id q15sm1323090qtx.47.2021.03.24.05.56.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 05:56:49 -0700 (PDT) Subject: Re: [hurd,commited] htl: Add missing fork.h To: Samuel Thibault Cc: libc-alpha@sourceware.org References: <20210324002015.338244-1-samuel.thibault@ens-lyon.org> <20210324123136.x5ab7fkrcm557enm@begin> <6aa8826c-b8ab-d999-4b99-e61c27282587@linaro.org> <20210324124532.sp6nkal764gwyatj@begin> From: Adhemerval Zanella Message-ID: Date: Wed, 24 Mar 2021 09:56:47 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210324124532.sp6nkal764gwyatj@begin> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 12:56:51 -0000 On 24/03/2021 09:45, Samuel Thibault wrote: > Adhemerval Zanella, le mer. 24 mars 2021 09:40:36 -0300, a ecrit: >> Why exactly tst-atfork2 fails without this includes? > > It misses the atfork unregister hook called at module unload. Ok, but *why* exactly? The sysdeps/htl/pt-atfork.c already includes register-atfork.h after the fork.h inclusion. What the missing includes misses to define on hurd implementation?