From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>,
Samuel Thibault <samuel.thibault@gnu.org>,
Sergey Bugaev <bugaevc@gmail.com>
Subject: Re: [PATCH v2] io: Refactor close_range and closefrom
Date: Wed, 24 Nov 2021 09:43:30 -0300 [thread overview]
Message-ID: <e111fb3f-16ab-8454-782a-d52401ba3567@linaro.org> (raw)
In-Reply-To: <b22e5281-6225-f310-081b-e496938a673f@linaro.org>
On 24/11/2021 09:20, Adhemerval Zanella wrote:
>
>
> On 24/11/2021 09:03, Florian Weimer wrote:
>> * Adhemerval Zanella:
>>
>>>> diff --git a/sysdeps/mach/hurd/kernel-features.h b/sysdeps/mach/hurd/kernel-features.h
>>>> index 7d4eaee0a6..5fd37a6d7b 100644
>>>> --- a/sysdeps/mach/hurd/kernel-features.h
>>>> +++ b/sysdeps/mach/hurd/kernel-features.h
>>>> @@ -19,3 +19,5 @@
>>>> /* This file can define __ASSUME_* macros checked by certain source files.
>>>> Almost none of these are used outside of sysdeps/unix/sysv/linux code.
>>>> But those referring to POSIX-level features like O_* flags can be. */
>>>> +
>>>> +#define __ASSUME_CLOSE_RANGE 1
>>>
>>> It does add it here (I also checked with a build for i688-gnu).
>>
>> Hmm, this doesn't match existing practice. We haven't unified
>> implementations in light of such divergence, I think. If the Hurd
>> developers don't object, it should be fine, though..
>
> This was used before, we still have some leftovers from it:
>
> nscd/nscd.c:306:# ifndef __ASSUME_IN_NONBLOCK
On a side note, I think we can just remove it since it is only used
with inotify_init1 (which is only supported on Linux and currently
on all minimum supported kernel).
> resolv/res_send.c:1035:#ifndef __ASSUME_SENDMMSG
> resolv/res_send.c:1081:#ifndef __ASSUME_SENDMMSG
> resolv/res_send.c:1100:#ifndef __ASSUME_SENDMMSG
And we might remove it by implementing sendmmsg/recvmmsg on top of
sendmsg/recvmsg on generic implementations.
>
> You have also cleanup some other assumes from Hurd: dup3 (b48061e1a534a242),
> O_CLOEXEC (cef9b65376a04430), and accept4 (e92030239abb4038).
>
prev parent reply other threads:[~2021-11-24 12:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 17:28 Adhemerval Zanella
2021-11-23 18:29 ` Adhemerval Zanella
2021-11-24 9:52 ` Florian Weimer
2021-11-24 11:36 ` Adhemerval Zanella
2021-11-24 12:03 ` Florian Weimer
2021-11-24 12:17 ` Samuel Thibault
2021-11-24 12:20 ` Adhemerval Zanella
2021-11-24 12:43 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e111fb3f-16ab-8454-782a-d52401ba3567@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=bugaevc@gmail.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=samuel.thibault@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).