From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id E5D523857820 for ; Mon, 4 Apr 2022 19:59:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E5D523857820 Received: by mail-ot1-x331.google.com with SMTP id b17-20020a0568301df100b005ce0456a9efso7965513otj.9 for ; Mon, 04 Apr 2022 12:59:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=BUXphwey35XcnHUq0DQw1746cWNMTY5s5ITT11mbU8c=; b=zRAW+qkmymBf6Dh7Rsj7nmp9PIxWPhBKDq0Z+X7ntIlvQ0U+AjWrXzP8YWBKzi5o4t iOlnZT5QOH7qK6G9cr3uwOG7SpiXE3JgxVVaiAnZDqnzcba8tYEKRzpv5Ztir4Ul9i4m +KJiT62pUYJfMXQjydv16OK7Y1V1CC89FB+TNca7XBeiH1CeKkSwiwp7a4MjkIcpS/2o /9lEIzgZKac8ltJy6JVtP/v9D+ysxDnb/wzUApK0/x8eFLL1qECdbw6X7TDSCqUNYrcj ZkWwON21MJwGjwlZOiegx0VbGI8YxfCRn5bkX4sYmTnJe2tOKeotyk+l6nzD5jpvmlYy q+tA== X-Gm-Message-State: AOAM530Yn3l+py9B/6lqjPwpc0lReebNInFgghS7EYxfADV2dsOb+jHS BobRf+gg6NVYxHRH9zn5uEuXz5lwPoxnmw== X-Google-Smtp-Source: ABdhPJwYeN+Gn+tXv9bNBKBYttXNAjhSt0iE9RkBnoiJk+T8EAhnVgW2A8M6dOYceeoHp2QpC/PCWw== X-Received: by 2002:a9d:410:0:b0:5cb:562a:5544 with SMTP id 16-20020a9d0410000000b005cb562a5544mr895otc.23.1649102398010; Mon, 04 Apr 2022 12:59:58 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:a6c0:94cf:60bc:16d1:2727? ([2804:431:c7cb:a6c0:94cf:60bc:16d1:2727]) by smtp.gmail.com with ESMTPSA id q83-20020aca5c56000000b002f94910a053sm4555478oib.56.2022.04.04.12.59.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Apr 2022 12:59:57 -0700 (PDT) Message-ID: Date: Mon, 4 Apr 2022 16:59:54 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] x86: Remove fabs{f} implementation Content-Language: en-US From: Adhemerval Zanella To: libc-alpha@sourceware.org References: <20220404193008.2808643-1-adhemerval.zanella@linaro.org> In-Reply-To: <20220404193008.2808643-1-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2022 20:00:00 -0000 It should have been marked as 'COMMITTED'. On 04/04/2022 16:30, Adhemerval Zanella wrote: > For x86_64 is the same as the generic implementation, while for i686 > the builtin generates the same code. > --- > sysdeps/i386/fpu/s_fabs.S | 10 ---------- > sysdeps/i386/fpu/s_fabsf.S | 10 ---------- > sysdeps/x86_64/fpu/s_fabs.c | 27 --------------------------- > sysdeps/x86_64/fpu/s_fabsf.c | 27 --------------------------- > 4 files changed, 74 deletions(-) > delete mode 100644 sysdeps/i386/fpu/s_fabs.S > delete mode 100644 sysdeps/i386/fpu/s_fabsf.S > delete mode 100644 sysdeps/x86_64/fpu/s_fabs.c > delete mode 100644 sysdeps/x86_64/fpu/s_fabsf.c