From: Carlos O'Donell <carlos@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
kemi <kemi.wang@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Tim Chen <tim.c.chen@intel.com>,
Andi Kleen <andi.kleen@intel.com>,
Ying Huang <ying.huang@intel.com>, Aaron Lu <aaron.lu@intel.com>,
Glibc alpha <libc-alpha@sourceware.org>,
aubrey <aubrey.li@intel.com>
Subject: Re: [PATCH 1/3] Tunables: Add tunables of spin count for adaptive spin mutex
Date: Thu, 05 Apr 2018 01:11:00 -0000 [thread overview]
Message-ID: <e1f5530c-b7eb-55ba-1784-3032ce657939@redhat.com> (raw)
In-Reply-To: <f65e64f5-7289-faa4-2314-71ce5e904bf0@linaro.org>
On 04/04/2018 12:16 PM, Adhemerval Zanella wrote:
>>> Also I not sure if it worth to add environment variable for this tunable,
>>> I would rather avoid adding newer ones (and naming seems off, since afaik
>>> LD_* meaning some parameters that affects the loader).
>>>
>>
>> AFAIK, environment variable is what I can think of to give people the possibility of
>> tunes in shell for that, maybe you have better idea?
>>
>> Yes, we probably use other name like MUTEX_SPIN_COUNT to avoid confusion, agree?
>
> The tunables framework already provides a environment variable to this [1],
> the 'env_alias' is mainly to provide compatibility and to use the same logic
> internally.
>
> So I think it is better to use the default tunable env var.
>
> [1] https://www.gnu.org/software/libc/manual/html_node/Tunables.html
Fully agree. We should never add any new environment variable, they should all be
automatically used from the top-level tunable env var.
--
Cheers,
Carlos.
prev parent reply other threads:[~2018-04-05 1:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 7:17 Kemi Wang
2018-03-30 7:17 ` [PATCH 3/3] Mutex: Avoid useless spinning Kemi Wang
2018-04-05 20:59 ` Adhemerval Zanella
2018-04-08 8:33 ` kemi
2018-03-30 7:17 ` [PATCH 2/3] Mutex: Only read while spinning Kemi Wang
2018-04-05 20:55 ` Adhemerval Zanella
2018-04-08 8:30 ` kemi
2018-04-09 20:52 ` Adhemerval Zanella
2018-04-10 1:49 ` kemi
2018-04-11 13:28 ` Adhemerval Zanella
2018-04-02 15:19 ` [PATCH 1/3] Tunables: Add tunables of spin count for adaptive spin mutex Adhemerval Zanella
2018-04-04 10:27 ` kemi
2018-04-04 17:17 ` Adhemerval Zanella
2018-04-05 1:11 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1f5530c-b7eb-55ba-1784-3032ce657939@redhat.com \
--to=carlos@redhat.com \
--cc=aaron.lu@intel.com \
--cc=adhemerval.zanella@linaro.org \
--cc=andi.kleen@intel.com \
--cc=aubrey.li@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=kemi.wang@intel.com \
--cc=libc-alpha@sourceware.org \
--cc=tim.c.chen@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).