From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 2BD47384A022 for ; Fri, 9 Oct 2020 13:50:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2BD47384A022 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 099DYORS108986 for ; Fri, 9 Oct 2020 09:50:03 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 342pt459ej-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 09 Oct 2020 09:50:03 -0400 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 099DYS9P109272 for ; Fri, 9 Oct 2020 09:50:02 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0b-001b2d01.pphosted.com with ESMTP id 342pt459e7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Oct 2020 09:50:02 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 099Dffwf008151; Fri, 9 Oct 2020 13:50:02 GMT Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by ppma01dal.us.ibm.com with ESMTP id 3429hq71xm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Oct 2020 13:50:01 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 099Do0Q653936634 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 Oct 2020 13:50:00 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B5F7BBE051; Fri, 9 Oct 2020 13:50:00 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B87E1BE04F; Fri, 9 Oct 2020 13:49:59 +0000 (GMT) Received: from [9.65.239.149] (unknown [9.65.239.149]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 9 Oct 2020 13:49:59 +0000 (GMT) Subject: Re: [PATCH 14/28] elf: Enhance ld.so --help to print HWCAP subdirectories To: Florian Weimer , libc-alpha@sourceware.org References: From: Matheus Castanho Message-ID: Date: Fri, 9 Oct 2020 10:49:58 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-09_06:2020-10-09, 2020-10-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 lowpriorityscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010090094 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Oct 2020 13:50:05 -0000 Hi Florian, After this patch was merged I started seeing the following error when building with --disable-tunables: l-usage.c: In function ‘print_legacy_hwcap_directories’: dl-usage.c:153:11: error: ‘HWCAP_IMPORTANT’ undeclared (first use in this function) if (HWCAP_IMPORTANT & bit) ^~~~~~~~~~~~~~~ dl-usage.c:153:11: note: each undeclared identifier is reported only once for each function it appears in dl-usage.c:155:31: error: implicit declaration of function ‘_dl_hwcap_string’; did you mean ‘_dl_fatal_printf’? [-Werror=implicit-function-declaration] _dl_printf (" %s", _dl_hwcap_string (n)); ^~~~~~~~~~~~~~~~ _dl_fatal_printf dl-usage.c:155:27: error: format ‘%s’ expects argument of type ‘char *’, but argument 2 has type ‘int’ [-Werror=format=] _dl_printf (" %s", _dl_hwcap_string (n)); ~^ ~~~~~~~~~~~~~~~~~~~~ %d cc1: all warnings being treated as errors make[2]: *** [../o-iterator.mk:9: /home/tcbot/bot-worker/glibc-ppc64le-power8-notunables/vpath/elf/dl-usage.os] Error 1 I could reproduce this on both ppc64le and x84_64 with --disable-tunables. Are we missing an `#include `? diff --git a/elf/dl-usage.c b/elf/dl-usage.c index c07f43835b..796ad38b43 100644 --- a/elf/dl-usage.c +++ b/elf/dl-usage.c @@ -22,6 +22,7 @@ #include #include "version.h" +#include #include void -- Matheus Castanho