From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>,
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 3/3] pthread: Remove alloca usage from __sem_check_add_mapping
Date: Mon, 8 Feb 2021 13:31:17 -0300 [thread overview]
Message-ID: <e3583b1f-8513-50ea-343a-68da18f6505f@linaro.org> (raw)
In-Reply-To: <87pn1c9qfn.fsf@oldenburg.str.redhat.com>
On 07/02/2021 06:29, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
>
>> sem_open already returns EINVAL for input names larger than NAME_MAX,
>> so it can assume the largest name length to with tfind.
>
> Typo: “to with”
Ack.
>
>> @@ -61,6 +70,9 @@ sem_t *
>> __sem_check_add_mapping (const char *name, int fd, sem_t *existing)
>> {
>> size_t namelen = strlen (name);
>> + if (namelen > NAME_MAX)
>> + return NULL;
>> +
>> sem_t *result = SEM_FAILED;
>
> Should this return SEM_FAILED?
It should, I have fixed it.
>
> Thanks,
> Florian
>
next prev parent reply other threads:[~2021-02-08 16:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 18:34 [PATCH 1/3] linux: Require /dev/shm as the shared memory file system [BZ #25383] Adhemerval Zanella
2021-02-03 18:34 ` [PATCH 2/3] pthread: Refactor semaphore code Adhemerval Zanella
2021-02-07 9:30 ` Florian Weimer
2021-02-03 18:34 ` [PATCH 3/3] pthread: Remove alloca usage from __sem_check_add_mapping Adhemerval Zanella
2021-02-07 9:29 ` Florian Weimer
2021-02-08 16:31 ` Adhemerval Zanella [this message]
2021-02-09 19:03 ` [COMMITTED] linux: Fix __sem_check_add_mapping search_sem Adhemerval Zanella
2021-02-07 9:23 ` [PATCH 1/3] linux: Require /dev/shm as the shared memory file system [BZ #25383] Florian Weimer
2021-02-09 17:44 ` [COMMITTED] linux: Fix __sem_check_add_mapping name length Adhemerval Zanella
2021-02-09 18:44 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3583b1f-8513-50ea-343a-68da18f6505f@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).