From: Carlos O'Donell <carlos@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Martin Sebor <msebor@gmail.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v3 5/5] avoid -Wuse-after-free [BZ #26779]
Date: Fri, 28 Jan 2022 12:33:56 -0500 [thread overview]
Message-ID: <e37afc46-2930-2917-0c1a-6bed103370da@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2201281307110.623452@digraph.polyomino.org.uk>
On 1/28/22 08:10, Joseph Myers wrote:
> Note that there are still -Wuse-after-free build failures in the testsuite
> for many 32-bit platforms. E.g., on i686-linux-gnu:
>
> tst-mallocalign1.c: In function 'do_test':
> tst-mallocalign1.c:69:1: error: pointer 'p' used after 'free' [-Werror=use-after-free]
> 69 | }
> | ^
> tst-mallocalign1.c:42:3: note: call to 'free' here
> 42 | free (p);
> | ^~~~~~~~
>
> Also, the s390x-linux-gnu-O3 build-many-glibcs.py configuration shows
> failures:
>
> In function 'do_test',
> inlined from 'legacy_test_function' at ../test-skeleton.c:55:10:
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
> tst-realloc.c:134:12: error: pointer 'p' may be used after 'realloc' [-Werror=use-after-free]
> 134 | if (c[i] != 0xff)
> | ~^~~
> tst-realloc.c:124:7: note: call to 'realloc' here
> 124 | c = realloc (p, -1);
> | ^~~~~~~~~~~~~~~
>
I'm going to look at these right now. I want clean gcc 12 glibc 2.35 results before
we release.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2022-01-28 17:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 0:21 [PATCH] " Martin Sebor
2022-01-16 2:25 ` Paul Eggert
2022-01-21 23:14 ` Martin Sebor
2022-01-22 0:42 ` Paul Eggert
2022-01-25 0:42 ` Martin Sebor
2022-01-25 1:08 ` Jeff Law
2022-01-18 9:48 ` Florian Weimer
2022-01-20 21:50 ` Martin Sebor
2022-01-25 0:52 ` [PATCH v2 0/5] " Martin Sebor
2022-01-25 0:57 ` [PATCH v2 1/5] " Martin Sebor
2022-01-25 17:46 ` Carlos O'Donell
2022-01-25 0:58 ` [PATCH v2 2/5] " Martin Sebor
2022-01-25 17:46 ` Carlos O'Donell
2022-01-25 0:58 ` [PATCH v2 3/5] " Martin Sebor
2022-01-25 17:47 ` Carlos O'Donell
2022-01-25 0:58 ` [PATCH v2 4/5] " Martin Sebor
2022-01-25 17:49 ` Carlos O'Donell
2022-01-25 17:51 ` Carlos O'Donell
2022-01-25 21:47 ` Florian Weimer
2022-01-26 13:55 ` Carlos O'Donell
2022-01-25 0:58 ` [PATCH v2 5/5] " Martin Sebor
2022-01-25 17:49 ` Carlos O'Donell
2022-01-25 22:50 ` [PATCH v3 " Martin Sebor
2022-01-26 14:56 ` Carlos O'Donell
2022-01-28 13:10 ` Joseph Myers
2022-01-28 17:33 ` Carlos O'Donell [this message]
2022-01-28 17:51 ` Joseph Myers
2022-01-28 23:21 ` Jeff Law
2022-01-31 15:12 ` Carlos O'Donell
2022-02-04 20:40 ` Joseph Myers
2022-01-25 17:46 ` [PATCH v2 0/5] " Carlos O'Donell
2022-01-26 3:08 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e37afc46-2930-2917-0c1a-6bed103370da@redhat.com \
--to=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).