From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by sourceware.org (Postfix) with ESMTPS id 0343839540EF for ; Wed, 21 Oct 2020 11:03:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0343839540EF Received: by mail-qt1-x844.google.com with SMTP id t9so1578919qtp.9 for ; Wed, 21 Oct 2020 04:03:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=sZiCdjw+c1ykF11P0JjRQc4c0BuqyIReT1cR351Sgbc=; b=hrJ7EYAkzjI8ZdLbpHhyNd0cxg2kBsZtloHnU0+5YV+qC2e0oIJkJE+whZ22bAeAAs e+tQIcvSNUuFck/vJuKJxArKDCb5lI+ws0Yvryj6rberKbedbuRINAyvlCgmuGxUf/xd xqrSWvMoFdjbYQOxMqsIhWOAa6MZyIFr0QFb79a+f3Ch3JMm4kImcii7cbzvCFHkIk54 pgtjSPFtwTw85wFaQozIc4xSV1FZSJD8MXCZS8kofGgwg6sKZlg51kKs8eYnyQsXFSKZ jRQ51Xe1c7AHZY2ePfHU9fHzTRTKwrmGIrQPPrwnV3CWxymGHy32LeCqE4ELZ24FYgKi 3Yqg== X-Gm-Message-State: AOAM5306BZStHsAHvAU0c0iAQg8BR7OCzIKPJFJlLEM6n1Wk0wbP3Tu5 ecyoG3Bnncl81pWWRzJFtOzeYSV0XiM1cg== X-Google-Smtp-Source: ABdhPJwAskMr+g5gig1DmIQArjBZN9+WwLupU/3evT4jXn4BSd/64Ep6WpSCvwHo/XN7bKaPdWveGg== X-Received: by 2002:ac8:7b2a:: with SMTP id l10mr2456683qtu.222.1603278217039; Wed, 21 Oct 2020 04:03:37 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id b33sm905534qtk.38.2020.10.21.04.03.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Oct 2020 04:03:36 -0700 (PDT) To: Florian Weimer Cc: libc-alpha@sourceware.org References: <20201019191304.3471080-1-adhemerval.zanella@linaro.org> <87h7qo2m4d.fsf@oldenburg2.str.redhat.com> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH 1/2] Reinstate ftime and move define it for POSIX.1-2001 or older Message-ID: Date: Wed, 21 Oct 2020 08:03:33 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87h7qo2m4d.fsf@oldenburg2.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2020 11:03:41 -0000 On 21/10/2020 02:17, Florian Weimer wrote: > * Adhemerval Zanella: > >> diff --git a/NEWS b/NEWS >> index 6eb577a669..6105eb0b3e 100644 >> --- a/NEWS >> +++ b/NEWS >> @@ -37,10 +37,8 @@ Deprecated and removed features, and other changes affecting compatibility: >> implementations from HWCAP subdirectories are no longer loaded. >> Instead, the default implementation is used. >> >> -* The deprecated header and the ftime function have been >> - removed. To support old binaries, the ftime function continue to exist >> - as a compatibility symbol (on those architectures which had it). All >> - programs should use gettimeofday or clock_gettime instead. >> +* The deprecated ftime function is now only declared for POSIX.1-2001 or >> + older standard. > > It is also declared for _GNU_SOURCE, so the NEWS entry is not correct. I removed the entry. > >> diff --git a/include/features.h b/include/features.h >> index f3e62d3362..aec149ed10 100644 >> --- a/include/features.h >> +++ b/include/features.h >> @@ -143,6 +143,7 @@ >> #undef __GLIBC_USE_ISOC2X >> #undef __GLIBC_USE_DEPRECATED_GETS >> #undef __GLIBC_USE_DEPRECATED_SCANF >> +#undef __GLIBC_USE_DEPRECATED_FTIME >> >> /* Suppress kernel-name space pollution unless user expressedly asks >> for it. */ >> @@ -438,6 +439,15 @@ >> # define __GLIBC_USE_DEPRECATED_SCANF 0 >> #endif >> >> +/* The function 'ftime' appeared in Version 7 AT&T UNIX, it was marked >> + as LEGACY on IEEE 1003.1-2004, and removed on IEEE 1003.1-2008. */ >> +#if (defined _POSIX_C_SOURCE && (_POSIX_C_SOURCE - 0) <= 200112L) \ >> + || defined _XOPEN_SOURCE_EXTENDED >> +# define __GLIBC_USE_DEPRECATED_FTIME 1 >> +#else >> +# define __GLIBC_USE_DEPRECATED_FTIME 0 >> +#endif > > Due to the _XOPEN_SOURCE_EXTENDED part, this does not seem particularly > useful. Not a strong position here, I will remove since it will defined anyway for most scenarios. > >> diff --git a/time/sys/timeb.h b/time/sys/timeb.h >> new file mode 100644 >> index 0000000000..be7b46c178 >> --- /dev/null >> +++ b/time/sys/timeb.h >> @@ -0,0 +1,48 @@ >> +/* Copyright (C) 1994-2020 Free Software Foundation, Inc. >> + This file is part of the GNU C Library. >> + >> + The GNU C Library is free software; you can redistribute it and/or >> + modify it under the terms of the GNU Lesser General Public >> + License as published by the Free Software Foundation; either >> + version 2.1 of the License, or (at your option) any later version. >> + >> + The GNU C Library is distributed in the hope that it will be useful, >> + but WITHOUT ANY WARRANTY; without even the implied warranty of >> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + Lesser General Public License for more details. >> + >> + You should have received a copy of the GNU Lesser General Public >> + License along with the GNU C Library; if not, see >> + . */ >> + >> +#ifndef _SYS_TIMEB_H >> +#define _SYS_TIMEB_H 1 >> + >> +#include >> + >> +#include >> + >> +__BEGIN_DECLS >> + >> +#if __GLIBC_USE (DEPRECATED_FTIME) > > I'm not sure if that #if is particularly useful. For later POSIX, this > is a non-standard header, so there is no conformance issue. Indeed. > >> + >> +/* Structure returned by the `ftime' function. */ >> + >> +struct timeb >> + { >> + time_t time; /* Seconds since epoch, as from `time'. */ >> + unsigned short int millitm; /* Additional milliseconds. */ >> + short int timezone; /* Minutes west of GMT. */ >> + short int dstflag; /* Nonzero if Daylight Savings Time used. */ >> + }; > > Missing __attribute_deprecated_msg__. Ack. > >> + >> +/* Fill in TIMEBUF with information about the current time. */ >> + >> +extern int ftime (struct timeb *__timebuf) >> + __nonnull ((1)) __attribute_deprecated__; > > Please use __attribute_deprecated_msg__, pointing towards clock_gettime. > > Should these deprecations be disabled for older POSIX? I think we should enforce these interface are really deprecated, and clock_gettime is provided with _POSIX_C_SOURCE >= 199309L. > > Thanks, > Florian >