From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id EA5033858CD1 for ; Thu, 7 Nov 2024 17:13:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EA5033858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EA5033858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.83.234.184 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730999610; cv=none; b=mqvrZa7ZkN9wvBFKasatsyN+X5xir490VqtLnL2+shNClKJ0r3oFhPHEsPD9H36C8nWbEprnqAycr5c5d70S4wR6/2K5L8HkZ5z3yE39T1s9UwMRIPruzYQpiDAFF7n8uJy0sYCLHHwnlozzUXNtkVtpmBNhccJYG1a766Ix/ZY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730999610; c=relaxed/simple; bh=Qz0DBKvcN/HfhQaSgswj8k4pRLvDBaqedHKIAH/eu3U=; h=Message-ID:Subject:From:To:Date:MIME-Version; b=wNKcCARSva2wyJjcmpBkhzyBCRiRnHH+OndK0Pmm9nj+trwA2/DWxqHM9Innd7O3wkCMG1e9BVlyXGsiekw2niYS7ZGdzNe+tPl9IJUtzm0nABlDVf0IPj4VFm3PCfj9nG4Gs/8VmHDhEeveXZhFybjEAQpZePYvRRIZf2QX/Dc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 9A6FC303C2A0; Thu, 7 Nov 2024 18:13:27 +0100 (CET) Received: by r6.localdomain (Postfix, from userid 1000) id 1BE163403A8; Thu, 7 Nov 2024 18:13:27 +0100 (CET) Message-ID: Subject: Re: cacosh/csin failures on s390x since CORE-MATH integration From: Mark Wielaard To: Adhemerval Zanella Netto , libc-alpha@sourceware.org Date: Thu, 07 Nov 2024 18:13:26 +0100 In-Reply-To: <2d500943-2c3d-4fb8-b672-b1b3fb2981fe@linaro.org> References: <1e193ae7f5eec66b437f81eda54e56f23c7bc848.camel@klomp.org> <2d500943-2c3d-4fb8-b672-b1b3fb2981fe@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Adhemerval, On Thu, 2024-11-07 at 13:40 +0000, Adhemerval Zanella Netto wrote: > It is expected [1], I had to adjust it on x86, arm, and powerpc as well. > The __expm1 is exact for the input range, but due how csin/cacoshf > handles the expm1 result there is addition cancellation errors. >=20 > In this case someone will need to run 'make update-ulps' on a real > hardware and update the libm-test-ulps.=20 Aha, found https://sourceware.org/glibc/wiki/Regeneration#Math_files Running make regen-ulps on an s390x machine produced: Automatic regeneration of ULPs complete. Difference between the current baseline and the new baseline is: --- ../sysdeps/s390/fpu/libm-test-ulps 2024-11-07 16:53:35.036318696 +0000 +++ /home/mjw/glibc-obj/math/NewUlps 2024-11-07 17:09:45.376836323 +0000 @@ -228,7 +228,7 @@ =20 Function: Real part of "cacosh_upward": double: 4 -float: 3 +float: 4 ldouble: 6 =20 Function: Imaginary part of "cacosh_upward": @@ -720,6 +720,7 @@ ldouble: 1 =20 Function: Imaginary part of "csin": +float: 1 ldouble: 1 =20 Function: Real part of "csin_downward": Copy /home/mjw/glibc-obj/math/NewUlps to ../sysdeps/s390/fpu/libm-test-ulps= (relative to source). Will sent a patch after another make check run to verify the results. Thanks, Mark > [1] https://sourceware.org/pipermail/libc-alpha/2024-October/161131.html