From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 24AC03858D32 for ; Mon, 5 Feb 2024 13:57:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 24AC03858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 24AC03858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::531 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707141461; cv=none; b=xD5NGM9QGDYjGcJ+06UvSH7AU58LAt0wepd7sjGqryVjbOvwJ4h2wylyKsvEhY3I/Z86sVZwCDmKWWvvOq5pAHfrdOKxe0vr2vFcX3SEDsaZYqMCjTgZmsm/KNrbaMfz6niCYxw/Tzau+wJbclIDpulIJwW2dY7zBveLmOP7KDo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707141461; c=relaxed/simple; bh=n7VunnD7JxRpJgxR7detQ/pdgafumRKmtD5xxuMISAE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=qecaqc5osymOBXKX6R9f6v582i58CyyPc/AUN0r5HysPnDA44cGY5LlqG9U0mdbY1rOaaasCUigD6ZoJaQY/LLmHBr/U1ceN/a8iuQuUio7jIRyhRm5ocNFZhaskhqVMFUiM7gC3+nE0NqJNAQszIP1ZsdyrJkZuCjSw/dKjJCU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-5dc11fdddd6so1387296a12.1 for ; Mon, 05 Feb 2024 05:57:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707141458; x=1707746258; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=OFDEE+jBSNKE/SubIKR1gcVbGE5BNO9LQ9PQw1telGw=; b=un6aqGqklEowE+FItCmiL4V7rnWLNQM4VER65p2bOKuff4CtIGWozcPHwyla2a2YjV Zt4WYVm99nQvHnfHBDFoFizgR1lyz2u9G9KoXVq56p0LyGck/Ju0hm3hw+6HiIDM0urp sn5xQodKATrGxwvw+nrsEF6QSesmserrCP/OamjsMe+17DtzpflF+AiT/taNLvi84Uwg RNxWO5VyLSw80WnoSevbY4LeZKb9u+bNzJ/cc6RnGk0WnulnH1tXJnCCRzI+IbAt91wa 41FzJikQM2xgy1PrDv8PJPFISNyG6VUaL+AuIlqEVem+5Dc7/us2OkNzSbefbRm++wl2 ataw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707141458; x=1707746258; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OFDEE+jBSNKE/SubIKR1gcVbGE5BNO9LQ9PQw1telGw=; b=UXLgpgRVSQhpHHHBIH9efwKymIQre8GFj25JjkMPwp/6MOnpKdHqphhHczyUlRENTF RewPFy4V1tYiH0s42os+GF3GWMTOUyEecSNKKmKOUh67uiZ6WXw3Y0+mdzZqRDknQwLg vJ1b54oJIlNQ/+YnUAz4r7XLEdjLvIc94uDXln+ne+zToGNz26BCnLeyqs5hOCC8/ocM fFxTRvK4KXha1Ux749iatZL/Tov6cqxNo2DQFoLEzRHx6ThWWj7t1lkJ9ZSKi35rqTHa yYfbuhEHC9MQKw/BIpfEiDr+43FnUN8lbeFyFkNqoLAZnE/C+dcAVB+UWsvOhkbJq9S/ QTww== X-Gm-Message-State: AOJu0YzL6oJmNqbka6K6RCoeAoRzKjVgQsNtv3Y5R5i9EpILlaGXJ5Cq /VAIjh7ceQTFGiqFVYJwFLyQuOGk6e3SJj0lEUkF28L/9FH6RuFOF2JEC/YpfSE= X-Google-Smtp-Source: AGHT+IH9lsxDv9Ilme/uV//eaUlAQWVpmWS7toCQb9gRxhONPwZRNnwDWJylkJB+ACgcKQTvSsndWg== X-Received: by 2002:a05:6a20:230e:b0:19e:56f:7b18 with SMTP id n14-20020a056a20230e00b0019e056f7b18mr10554825pzc.56.1707141458135; Mon, 05 Feb 2024 05:57:38 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUJGgaYInnRWZYs+qoLFBmWenP6jiDaX2f+nzfvyJB1e3bjYW+ntd0Tl4FoTI5vZQ2ka0OZwHVAEsEmY3DHbzKDQuxqoGhXX+rK Received: from ?IPV6:2804:1b3:a7c3:574b:f1c3:db83:b701:fe0f? ([2804:1b3:a7c3:574b:f1c3:db83:b701:fe0f]) by smtp.gmail.com with ESMTPSA id p12-20020a631e4c000000b005d4156b3ea2sm6917167pgm.93.2024.02.05.05.57.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Feb 2024 05:57:37 -0800 (PST) Message-ID: Date: Mon, 5 Feb 2024 10:57:34 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] LoongArch: Use builtins for ffs and ffsll Content-Language: en-US To: Xi Ruoyao , libc-alpha@sourceware.org Cc: caiyinyu@loongson.cn References: <20240204002750.402652-1-xry111@xry111.site> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20240204002750.402652-1-xry111@xry111.site> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03/02/24 21:27, Xi Ruoyao wrote: > On LoongArch GCC compiles __builtin_ffs{,ll} to basically > `(x ? __builtin_ctz (x) : -1) + 1`. Since a hardware ctz instruction is > available, this is much better than the table-driven generic > implementation. > > Tested on loongarch64. > > Signed-off-by: Xi Ruoyao LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > sysdeps/loongarch/math-use-builtins-ffs.h | 2 ++ > 1 file changed, 2 insertions(+) > create mode 100644 sysdeps/loongarch/math-use-builtins-ffs.h > > diff --git a/sysdeps/loongarch/math-use-builtins-ffs.h b/sysdeps/loongarch/math-use-builtins-ffs.h > new file mode 100644 > index 0000000000..a83bb15414 > --- /dev/null > +++ b/sysdeps/loongarch/math-use-builtins-ffs.h > @@ -0,0 +1,2 @@ > +#define USE_FFS_BUILTIN 1 > +#define USE_FFSLL_BUILTIN 1