From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 4C14438A28BF for ; Mon, 26 Jul 2021 14:29:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C14438A28BF Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-359-eySENVjVPzWd-QsWZtysww-1; Mon, 26 Jul 2021 10:29:50 -0400 X-MC-Unique: eySENVjVPzWd-QsWZtysww-1 Received: by mail-qk1-f198.google.com with SMTP id y3-20020ae9f4030000b02903b916ae903fso9108155qkl.6 for ; Mon, 26 Jul 2021 07:29:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=E64mRVmrkZ2lDtTPkyVfzIoiYVQ28NqR9GSL9IyH7rs=; b=Nt+WP5BQ5THEjRMl+K6fjHTcocMV13PcGeWJeKEklQ0buUJekQwGZqCrXQcDyPJUqM h0RbDS+//sGQRjpZcscNky1COxSkF1TPefCSY9oMlok/2UGAAFWC8Gtb5x48fu+y6uAn pnsi+KivwLsMkSqkIfaFXNWcntgSrbljmJhjpURmc16MssFw3IBWzVNVE1rMS7zTnaaM t2KPsXVu4290haEAlh3mgEiU1ciCQoxAgdz9xTNSHEHmDCqbTpK54d5JX5rfF1qrczlu kXLoP6AotxAK5miunR31BtnhEslx4C9BwHb75vcAykFo3OakMgLdRXHE6UlxjcJ5adMe 18mA== X-Gm-Message-State: AOAM5302IYiMEBjdv6FfqUrq1hGqa/iu8m9PwI8Y3q3odoAJp6IRiFe0 ktKt67qYg9MiWujffeHoFhD4c06bubNXgY16ncP/ZScFDWkPI1s1DqFbpP2KRvHu+3yduSI8i2t yVknM8Xo5NKKDSQ2jrj3RP+0BsWvtSYB5iVHDlbqWAzMnE/dHlag2llRTVAmEn6b41t6PPw== X-Received: by 2002:ac8:7cb5:: with SMTP id z21mr15287529qtv.34.1627309789601; Mon, 26 Jul 2021 07:29:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKwj6XYYrxI5MnyIatDZ3muqLGAfSuQXiJevYntEsstsAAV0OmjC6+r/iSEmQOSZp6n2amMQ== X-Received: by 2002:ac8:7cb5:: with SMTP id z21mr15287511qtv.34.1627309789374; Mon, 26 Jul 2021 07:29:49 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id x14sm84041qts.13.2021.07.26.07.29.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jul 2021 07:29:48 -0700 (PDT) Subject: Re: glibc 2.34 - Hard ABI freeze effective immediately. To: "H.J. Lu" Cc: libc-alpha References: <7dd68a51-0904-98f8-e4ce-3e4bdcb14dc4@redhat.com> <4b8bcc59-362a-21ac-b531-6be07d0c722a@redhat.com> From: Carlos O'Donell Organization: Red Hat Message-ID: Date: Mon, 26 Jul 2021 10:29:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jul 2021 14:29:54 -0000 On 7/25/21 3:46 PM, H.J. Lu wrote: > On Sun, Jul 18, 2021 at 7:16 PM Carlos O'Donell via Libc-alpha > wrote: >> >> On 7/4/21 10:43 PM, Carlos O'Donell wrote: >>> We are in slushy freeze right now. I'm reviewing the last of the ABI >>> changes we want to make in glibc 2.34. >> >> The ABI freeze is now hard freeze, I would like to avoid any further ABI >> changes that are not on this list. >> >> If you have an ABI change please reach and respond to this thread >> immediately with the request. >> >> I would like to spend this week and next fixing any remaining bugs >> and doing machine testing. >> >>> The ABI changes that are currently under review: >>> >>> - Move nss_dns into libc. >>> https://patchwork.sourceware.org/project/glibc/list/?series=2407 >> >> I have reviewed v2 and I think it should be included in 2.34. >> >> I have just reviewed the final v3 changes so this should go in on Monday. >> >>> - Remove malloc hooks. >>> https://patchwork.sourceware.org/project/glibc/list/?series=2406 >> >> I have reviewed v8 and I think it should be included in 2.34. >> >> I'll review a v9 for inclusion. >> >>> - nss_files move. >>> https://patchwork.sourceware.org/project/glibc/list/?series=2386 >> >> This was reviewed by Adhemerval and committed July 7th. >> >>> - Add close_range, closefrom, and posix_spawn_file_actions_closefrom_np >>> https://patchwork.sourceware.org/project/glibc/list/?series=2363 >> >> This was committed by Adhemerval on July 8th. >> >>> - Define PTHREAD_STACK_MIN to sysconf(_SC_THREAD_STACK_MIN) >>> https://patchwork.sourceware.org/project/glibc/list/?series=2345 >> >> I have reviewed this, and it was committed by HJ on July 9th. >> >>> - x86: Install [BZ #27958] >>> https://patchwork.sourceware.org/project/glibc/list/?series=2272 >> >> I have reviewed this and requested some changes. >> >> I have reviewed this again and I am discussing the final wording with HJ. >> >> I think this should be included in glibc 2.34 and we will get there. >> >> -- >> Cheers, >> Carlos. >> > > It was a mistake to export _r_debug from ld.so: > > https://sourceware.org/bugzilla/show_bug.cgi?id=28130 > > I'd like to deprecate _r_debug in glibc 2.34 and replace it with: > > /* Return the address of that structure used by the dynamic linker. */ > extern struct r_debug * __r_debug_location (void) __attribute_const__; > #define _r_debug (*__r_debug_location ()) > > so that I can extend struct r_debug for libraries loaded with dlmopen: > > https://gitlab.com/x86-psABIs/Linux-ABI/-/issues/2 This needs more review, and is too late for glibc 2.34. I'm happy to review the situation once we open glibc 2.35. I think that fixing _r_debug and discussing dlmopen will take several weeks to achieve consensus and review existing best practice and patches. Do you have a strong objection to waiting for glibc 2.35? -- Cheers, Carlos.