From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B2E833858D38 for ; Thu, 18 Apr 2024 13:27:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2E833858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B2E833858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713446846; cv=none; b=hGIMAak5/xOsFe5LfPB0Zjxc7GnaraKfk3HH7Usb/6/G7BR6w5FiresLH0vKr3miPLS1GmZqjK8e7yj6E4xQzJQ0lnIWXyXAelX4aKX7aG9FmW6ANr3cHTA7N6T+PkoQvpqhjb7rQpELvrIbGIMsGtAV1qWb/M9OvwrwmiA+ZD8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713446846; c=relaxed/simple; bh=9D9tVYi9s18d1v6BKsSDcvB+4mFpNlfgH83iGMrnZs4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=AxuRrxQ05GTkzCx0HOc0wirOVYjyeJGQTy9yfOGwjU7gB6J3OJaQubMM4ZNJ+sgK0qlUsb2VBLVkLlJzV4Eu927AdXWylQS3dZ9+vSLeJF8gkmEA/6bPx1HOT9U6R/t5qTFgVu+cv0HfBGgqm4IgwtTCRx/djcuuQG+v0gCLzCo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713446844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/ydkh2Im8+MPnt510kGphLrDxt9MIn13MNHXFJNUhXc=; b=TBmKt7DBrHSrsKfNk0Rco4iQPk0e7U1zkaHMrxKZocduQ4w2TefnQfFbfGrmF/vPmiZvEb SWaFFLEqLxqAFJYKffYzYEitkr35wawrqKCytkiW7QquzhzcNZ8aUhsoU/m3S5v/0LEa2H AiSaRS/iWSaX0PnhzRXodio7Nwpcwrs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-231-UUCuFe75P46opxD8tHNx_Q-1; Thu, 18 Apr 2024 09:27:22 -0400 X-MC-Unique: UUCuFe75P46opxD8tHNx_Q-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-418f3082647so1873645e9.0 for ; Thu, 18 Apr 2024 06:27:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713446841; x=1714051641; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/ydkh2Im8+MPnt510kGphLrDxt9MIn13MNHXFJNUhXc=; b=Mv5AUgchRvZiEqvNrFIx0vPXobED26psEo2Jz7mvpZ1UQd4iiuAhTrBEq/LFiG4+gn 2bFkX4ablkUqbCH4fX7byF7WMMLI7LdDG7xKzrdVgK9rs4YS5sfrypryFAxtqHz/yk/2 DM/Tn4qEgNrd8YvVmbiyLpJolgPhnWSV0UNGbot7IHC9eGsgf3M5uFYKJ7OhpN9bZ1qC hRaTkVfafFSHiK5MyNx0Fl+hrgPvSDZQF+tYsQ4LSBkCKr7Nrsd+EqvdABF9VCJhd1qH uuO9pgKIgvNO4GOqc4dkia3OqE+KmQ47IXI03+uCNgOkgnE8gJF5yPtfcQ35EXddskYj eWmg== X-Gm-Message-State: AOJu0YwfRJcRxTEMVc+bMjBOEop/MBTkC5CmM3e9x/6aooHZxsxCZ1Rb j1r5gjBDnZ+/E1yfDsDbu9FPHZYK/6PQQJls9FDpOGZDoqjn4rbpZUPVWXMt44frbxIH6JZ1Ko5 ccgDYBc+fkS7M/jgkGeFZFZyNNbzzvEgY7DqVO/RvrL4wIHWwH5qmOgvmRA== X-Received: by 2002:a05:600c:1990:b0:418:f568:da36 with SMTP id t16-20020a05600c199000b00418f568da36mr585975wmq.23.1713446841740; Thu, 18 Apr 2024 06:27:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFtDyB+jH1R/ezlLMmRnzIZg+F3HyJx0R1R9FtD0LrNP0vlYq/LpkViV4SsD8Ie17R00brWHQ== X-Received: by 2002:a05:600c:1990:b0:418:f568:da36 with SMTP id t16-20020a05600c199000b00418f568da36mr585954wmq.23.1713446841313; Thu, 18 Apr 2024 06:27:21 -0700 (PDT) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id w14-20020a05600c474e00b00417bab31bd2sm2753123wmo.26.2024.04.18.06.27.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 06:27:21 -0700 (PDT) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rxRmp-00EChI-LR; Thu, 18 Apr 2024 13:26:47 +0000 Date: Thu, 18 Apr 2024 13:26:47 +0000 (UTC) From: Joseph Myers To: Carlos O'Donell cc: libc-alpha@sourceware.org Subject: Re: Implement C23 log2p1 In-Reply-To: <7f721503-e65d-4901-9369-833c00b01004@redhat.com> Message-ID: References: <41a4a6c9-4942-a9be-9459-1aaeb44ffee8@redhat.com> <7f721503-e65d-4901-9369-833c00b01004@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 15 Apr 2024, Carlos O'Donell wrote: > This fails CI for glibc: > https://patchwork.sourceware.org/project/glibc/patch/41a4a6c9-4942-a9be-9459-1aaeb44ffee8@redhat.com/ New ulps failures are expected for new libm functions. I think it's appropriate for libm-test-ulps updates to be done by architecture maintainers or others testing on an architecture (not necessarily for every patch, sometimes such testers might batch updates and update libm-test-ulps for multiple architectures at a time), rather than expecting them all to be included in the initial patch or making such functions need a multi-stage patch process where the initial patch needs updating with more libm-test-ulps updates before commit. (There is a reasonable argument for having a single libm-test-ulps file that lists expected error bounds by format (e.g. binary64, binary128) not type, notwithstanding that sometimes multiple implementations are used for a given function for a given floating-point format, and notwithstanding that sometimes the ulps for a given implementation may depend on e.g. whether the compiler contracts operations when building it. But while we have the per-architecture files, I don't think we should expect new-function patches to update them for more than one architecture.) -- Joseph S. Myers josmyers@redhat.com