From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) by sourceware.org (Postfix) with ESMTPS id D3B313858D37 for ; Tue, 5 Apr 2022 21:15:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D3B313858D37 Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-d6ca46da48so754930fac.12 for ; Tue, 05 Apr 2022 14:15:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UXfL5VHsURu6tWy81CXXJ6RIjS2e/ZaofdRCuaa1qu4=; b=TL2dqTXAuQ2hwOXLEioVIoCXCspsskaa4kpPxijZM+ABZtwMiDGdpvluvmTie1SNNC gftHqBozqNGVY/mhC39s3ZsW1q84HFtiUBwp9BxTEN/YgVMWUjpu06IemNKm7WHNdlUd 09eE56Svqq2rK7WdFNpwpsNFkE+9tBvadU4Xmi0Qm+yeivVXzPSwfb/l5D/yDfRV/MB/ z+EBMis6A6Haz36xFFAqszTaMZnD2u4ZDnhm/owdblmB8Q7el1MHIPpnGwC0WkV6GMrn KPkdGAPXHUFp/ZbhZDabJUCGHu8NYEIivCQNMx4w8zKHP97iAnBHqM5pGAB6+ZyX0dDb DNxg== X-Gm-Message-State: AOAM530CSLHmAqUQzjrnl96IsiidSTS7nRH0VRUeooGLU1qRmIYhOdox eUMPIiLPhGZneKaEWPgx4MBobw== X-Google-Smtp-Source: ABdhPJyZgJ7NV6joiLDeXeCkFZIoED9v+wHosHhrDZJ5ippcrWuyg/oApXH8gLjQLhqmSP+5Te6ShQ== X-Received: by 2002:a05:6870:5893:b0:da:b3f:321b with SMTP id be19-20020a056870589300b000da0b3f321bmr2523199oab.203.1649193342166; Tue, 05 Apr 2022 14:15:42 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:a6c0:26f4:3c2a:73ae:3e2? ([2804:431:c7cb:a6c0:26f4:3c2a:73ae:3e2]) by smtp.gmail.com with ESMTPSA id os4-20020a0568707d0400b000e1e6ddcddbsm3684865oab.4.2022.04.05.14.15.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Apr 2022 14:15:41 -0700 (PDT) Message-ID: Date: Tue, 5 Apr 2022 18:15:39 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] Remove fno-unit-at-a-time make variable Content-Language: en-US To: Florian Weimer Cc: Adhemerval Zanella via Libc-alpha , =?UTF-8?B?RsSBbmctcnXDrCBTw7JuZw==?= References: <20220330050729.2176630-1-maskray@google.com> <0295bfe2-2f44-c15e-1628-acaf94fc407c@linaro.org> <20220330162311.pwg52gcrr5vnlabe@google.com> <7e7fdfdc-ddc8-cf5a-0525-f927b4ae1e39@linaro.org> <20220331034302.rzcu6gllo7ltkhjh@google.com> <20220404155703.vefk66cwnsnkhsih@google.com> <22f8e3aa-5af9-93a2-65fc-1889674103d6@linaro.org> <4570fa06-24b0-873a-09b6-d57c85dd1191@linaro.org> <914158c4-f52d-21ee-73e5-6ffe30faa0d4@linaro.org> <87k0c3wh6a.fsf@oldenburg.str.redhat.com> <06ae38bd-cccb-9f00-b23a-5a1232a26763@linaro.org> <87zgkzuvim.fsf@oldenburg.str.redhat.com> <87sfqruuvj.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87sfqruuvj.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2022 21:15:44 -0000 On 05/04/2022 17:40, Florian Weimer wrote: > * Adhemerval Zanella: > >> On 05/04/2022 17:26, Florian Weimer wrote: >>> * Adhemerval Zanella: >>> >>>> On 05/04/2022 14:53, Florian Weimer wrote: >>>>> * Adhemerval Zanella via Libc-alpha: >>>>> >>>>>> This is not what I am seeing on my clang branch, where clang with integrated >>>>>> moves the global asm directives to the top of the file. And it makes >>>>>> check-abi fail due the _sys_errlist/sys_errlist being with wrong value. >>>>> >>>>> You can move the directives to the bottom of the file by creating a >>>>> temporary .s file and #include that from a wrapper .S file that >>>>> #includes the .s file. >>>> >>>> Not sure I am following your suggestion here, do you mean get the -S >>>> output file from compiler? >>> >>> Yes, H.J. did that in earlier patches. But I didn't like it back then. 8-p >> >> For dl-debug-symbols.S? I might take it as an example. > > Yes, here's a link to one of the earlier patches: > > [PATCH] Extend struct r_debug to support multiple namespaces > Thanks, I found it on the my local inbox history. > > In the end, I think it was easier to use a manually written assembler > file in that case, with the constants filled in via the .sym expander. I think for this case, it would be simpler to use H.J strategy, I really don't want to re-implement what compiler might do to lay out a C array to assembler.