From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id A57673857C4C for ; Mon, 5 Apr 2021 11:10:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A57673857C4C Received: by mail-ed1-x531.google.com with SMTP id h10so12111870edt.13 for ; Mon, 05 Apr 2021 04:10:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Q2xbNJukARq+VedCoE4Ye3l23GLZqaHV5I0EQQCdBqs=; b=XoFkZn+pFn7TM4yYiBhuUMoNpQJYKTYuIb26G19TxJ1oeQHpUyGDq/Er+/GIPAi2lX AvEJ0jpGmC4My/GGdWW2raTikNml0o+XITmPD6F2HDQXT6SUbFhUsktu6QLDgHq+WklO XSMXTFZjYAQ/zNCMr7ua89OlpSMQGgA5oIa82Os4zxN759sDpa4TTQQdrxAWG1vYLzV+ ELE9RXC1DrY8JOUxXCGatmSfAPhrp+BT5ZftbQBuq0dKWYsqrxy8DUAgQ/kzjD7CiKkT cVv75ePH6So7k63+CCmgPBr+PkTymBKcvnu4s5vkFoChlY4fvNsRw8jITyAC0SdpXTn/ pCCg== X-Gm-Message-State: AOAM533tRg/LU3BGdf/dNgGM2hyNMVEPa00MzMttwI3u+eQxXxsxCeYu JJRHvy+lSj3q4p/Ex53zZWUKYVcz0q8= X-Google-Smtp-Source: ABdhPJynNXNyVaqIdveybHUzV4qRjOLnk1pD2WoRMG7hCceT4hg6JukNTsK+/diO+SL8pJXtSQGu0A== X-Received: by 2002:a05:6402:3049:: with SMTP id bu9mr31323824edb.104.1617621007590; Mon, 05 Apr 2021 04:10:07 -0700 (PDT) Received: from ?IPv6:2001:a61:2553:a401:cfc6:2039:a9ec:21ff? ([2001:a61:2553:a401:cfc6:2039:a9ec:21ff]) by smtp.gmail.com with ESMTPSA id a19sm1830401ejy.42.2021.04.05.04.10.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Apr 2021 04:10:07 -0700 (PDT) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, libc-alpha@sourceware.org Subject: Re: [PATCH v5 35/35] ioctl_getfsmap.2: Make clear why exactly is each header needed To: Alejandro Colomar References: <20210403194026.102818-1-alx.manpages@gmail.com> <20210404115847.78166-36-alx.manpages@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: Date: Mon, 5 Apr 2021 13:10:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210404115847.78166-36-alx.manpages@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Apr 2021 11:10:10 -0000 Hi Alex, On 4/4/21 1:58 PM, Alejandro Colomar wrote: > doesn't seem to be needed! > Only the include that provides the prototype doesn't need a comment. > > Also sort the includes alphabetically. > > Signed-off-by: Alejandro Colomar Patch applied. Again, I did of editing afterward. Thanks, Michael > --- > man2/ioctl_getfsmap.2 | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/man2/ioctl_getfsmap.2 b/man2/ioctl_getfsmap.2 > index 4ff1c8a90..f87fb5c7a 100644 > --- a/man2/ioctl_getfsmap.2 > +++ b/man2/ioctl_getfsmap.2 > @@ -25,9 +25,10 @@ > ioctl_getfsmap \- retrieve the physical layout of the filesystem > .SH SYNOPSIS > .nf > -.B #include > -.B #include > +.RB " /* Definition of " FS_IOC_GETFSMAP ", " FM?_OF_* ", and " *FMR_OWN_* \ > +" constants */" > .B #include > +.B #include > .PP > .BI "int ioctl(int " fd ", FS_IOC_GETFSMAP, struct fsmap_head * " arg ); > .fi > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/