Re: patchwork upgrade week

[Mark Wielaard <mark@klomp.org>]

Hi Siddhesh,

On Thu, 2022-06-23 at 07:46 +0530, Siddhesh Poyarekar wrote:
> On 23/06/2022 02:57, Mark Wielaard wrote:
> > So I was hoping to integrate the buildbot with the patchwork based
> > trybot. But it would be good to have some way to authenticate the
> > patch as genuine before throwing it at the buildbot-worker. I was
> > hoping that could be done by a project admin setting the state of the
> > patch to some "please-try" value. But it looks like a (rogue) user can
> > set the state on their own patch. So relying on the patchwork patch
> > state seems not secure.
> > 
> > Or is there a state (maybe a check state?) that we can make sure can
> > only be set by project admins?
> > 
> > If not, how else can we authenticate a patch as "OK to let the
> > buildbot do a try build?"
> 
> DJ is working on an email based workflow.  Another method (that Frank 
> proposed on IRC recently) could be for a trybot to track namespace 
> branches for all committers on sourceware and trigger builds on specific 
> names, e.g. siddhesh/buildbot/*.  That way maintainers can manually 
> trigger builds by pushing their changes to that specific branch namespace.

OK, so that would work like the git try branches, but tells the
buildbot to also find the same patch on patchwork to add a check
result?

Could we then use patchwork/hasher.py to calculate the hash of the
commit and look it up in the project patch list so it can be update it
with the builder check result?

That sounds like a promising idea.

Thanks,

Mark