From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com [IPv6:2607:f8b0:4864:20::a30]) by sourceware.org (Postfix) with ESMTPS id 26FAD38582A9 for ; Mon, 1 Aug 2022 20:01:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 26FAD38582A9 Received: by mail-vk1-xa30.google.com with SMTP id e3so4046059vkg.4 for ; Mon, 01 Aug 2022 13:01:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=9GCqezpB77mMuzSAjZSgTC/x7P2ITBG1uqKrWRphqM0=; b=GE6m5W3MR4FAjUUjj8QjaLU4L7TEe6fNx6uXJy81VYNV1Cb4rPscDpvWz3Gh9FEmSx nV8b58hNkED9R0UeZFtfh+Pd9grt4jKvt0NJDgTVbktXafVehCyGCsYHcqOj6qckG6kf AlIewQTlxm1J/gMMZufI5fdy65o+5cmz1JGdeITU4EnLGcEVvPYVO1Pp+FZdoE+ZOhrX eX95gI2XD6E1pkNM54Ih9H6e/Z5bnOnY7kq59XQR67R4vikUkfpf1QgJufho8IqqKTY5 BU3tk8xloayTmnyAnK/QAGr7/dHf6P3xs9kDwHDOx0h0RAQhY6iOoTNzmQgwDCqEn7UA GUJg== X-Gm-Message-State: ACgBeo1k4UvjAb1F3h2GMIQsBhFTfbZWPK03XV6Bl7u01iC6r0Yie/Yz thhIOXblYYDlL0X7iGF8Oku2U4wytwduYA== X-Google-Smtp-Source: AA6agR7FlSThWt7gJ7G9YFlxkGPD6PDsYpIG2EmZDRT/cS2XGBFmjakGtqHPu+26LBfTHHPHGnva6Q== X-Received: by 2002:a1f:258f:0:b0:377:500f:8e59 with SMTP id l137-20020a1f258f000000b00377500f8e59mr2938548vkl.11.1659384078240; Mon, 01 Aug 2022 13:01:18 -0700 (PDT) Received: from ?IPV6:2804:431:c7cb:1e34:a813:f55c:8e00:64cd? ([2804:431:c7cb:1e34:a813:f55c:8e00:64cd]) by smtp.gmail.com with ESMTPSA id x16-20020a1fae10000000b0037461da7ccfsm6582423vke.34.2022.08.01.13.01.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Aug 2022 13:01:17 -0700 (PDT) Message-ID: Date: Mon, 1 Aug 2022 17:01:15 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.0 Subject: Re: [PATCH 2/3] nptl: Remove uses of assert_perror Content-Language: en-US To: libc-alpha@sourceware.org References: <2d9e7fb75a80c85c50d6cbc227af2bde281c4fc6.1659350650.git.fweimer@redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <2d9e7fb75a80c85c50d6cbc227af2bde281c4fc6.1659350650.git.fweimer@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2022 20:01:21 -0000 On 01/08/22 07:45, Florian Weimer via Libc-alpha wrote: > __pthread_sigmask cannot actually fail with valid pointer arguments > (it would need a really broken seccomp filter), and we do not check > for errors elsewhere. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > sysdeps/nptl/gai_misc.h | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/sysdeps/nptl/gai_misc.h b/sysdeps/nptl/gai_misc.h > index c09350c2ed..4196eac6e6 100644 > --- a/sysdeps/nptl/gai_misc.h > +++ b/sysdeps/nptl/gai_misc.h > @@ -81,9 +81,7 @@ __gai_start_notify_thread (void) > { > sigset_t ss; > sigemptyset (&ss); > - int sigerr __attribute__ ((unused)); > - sigerr = __pthread_sigmask (SIG_SETMASK, &ss, NULL); > - assert_perror (sigerr); > + (void) __pthread_sigmask (SIG_SETMASK, &ss, NULL); > } > > extern inline int > @@ -106,15 +104,12 @@ __gai_create_helper_thread (pthread_t *threadp, void *(*tf) (void *), > sigset_t ss; > sigset_t oss; > sigfillset (&ss); > - int sigerr __attribute__ ((unused)); > - sigerr = __pthread_sigmask (SIG_SETMASK, &ss, &oss); > - assert_perror (sigerr); > + (void) __pthread_sigmask (SIG_SETMASK, &ss, &oss); > > int ret = __pthread_create (threadp, &attr, tf, arg); > > /* Restore the signal mask. */ > - sigerr = __pthread_sigmask (SIG_SETMASK, &oss, NULL); > - assert_perror (sigerr); > + (void) __pthread_sigmask (SIG_SETMASK, &oss, NULL); > > (void) __pthread_attr_destroy (&attr); > return ret;