From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 575F9385840B for ; Tue, 5 Oct 2021 14:27:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 575F9385840B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: M5bIcw0swdk31MWUPB6cfHwLgptJbsC4t1/jvVTmL0Jp9gY033b0yqVWnSyKoCb2jT7NvUB5/Q v9rGZ/Z2QPwSf7FRvHSh0uJhSLbpcD0GJfB3tn3F6F7uqe3apTVw/bNx9KxucPPvBoG1zJ5/Gd fAozB/iBMG7ozp7Zm/bioIHg00gBGuQF7Lxa4vy0g3mNoWYBj40yWtNAG/ehOFDMkwjWanp63i 7rtXT6qn6IsEUcvRuynZIibOBoRivBf6OcQ951NyvsckDrOdNPmNKclnCEdjfAPI+kARvFK0k0 Pf1/bAlhNhhNCMhQNlzzEHHF X-IronPort-AV: E=Sophos;i="5.85,349,1624348800"; d="scan'208";a="66834972" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 05 Oct 2021 06:27:35 -0800 IronPort-SDR: /CD9te4SX/aXHRPAPWM6nr2YCYik51x+Mc/UNz0PCpHrM1DAEy2mlHN2FZR+QGltt+jWGXZT3g 30R7H/zo/eGJOzXrmP/HyzJLwG7LDwwommktek/XjUO2f+RYJafaM5oayXNM1VdMxYEECW5ARI eDCzt2SiuZdHJoKfJzp1Lbzj2V04qrwafydduh0tFnwmedZsGBd6jO0+vmP6y7qQY3aNWuKlya Xbi2YMtGj3poOWTAwFhPuLlDPmaC1x2ICutrwabWrOgmJWjrXbNClN2LuNU+YtbX9OsziKQGlC 2pA= Subject: Re: [PATCH v6 1/2] BZ #17645, fix slow DSO sorting behavior in dynamic loader -- Testing infrastructure To: Adhemerval Zanella , GNU C Library , Florian Weimer References: <9fa7d32b-ded3-f9e1-3dd1-acfa9c770c71@linaro.org> From: Chung-Lin Tang Message-ID: Date: Tue, 5 Oct 2021 22:27:19 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <9fa7d32b-ded3-f9e1-3dd1-acfa9c770c71@linaro.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) To svr-orw-mbx-02.mgc.mentorg.com (147.34.90.202) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2021 14:27:38 -0000 Hi Adhemerval, thanks for the review. And thanks for all the style and proofreading adjustments. On 2021/8/11 2:05 AM, Adhemerval Zanella wrote: >> # Complex example from Bugzilla #15311, under-linked and with circular >> +# relocation(dynamic) dependencies. While this is technically unspecified, the >> +# presumed reasonable practical behavior is for the destructor order to respect >> +# the static DT_NEEDED links (here this means the a->b->c->d order). >> +# The older dynamic_sort=1 algorithm does not achieve this, while the DFS-based >> +# dynamic_sort=2 algorithm does, although it is still arguable whether going >> +# beyond spec to do this is the right thing to do. >> +# The below expected outputs are what the two algorithms currently produce >> +# respectively, for regression testing purposes. >> +tst-bz15311: {+a;+e;+f;+g;+d;%d;-d;-g;-f;-e;-a};a->b->c->d;d=>[ba];c=>a;b=>e=>a;c=>f=>b;d=>g=>c >> +output(glibc.rtld.dynamic_sort=1): {+a[d>c>b>a>];+e[e>];+f[f>];+g[g>];+d[];%d(b(e(a()))a()g(c(a()f(b(e(a()))))));-d[];-g[];-f[];-e[];-a[> +output(glibc.rtld.dynamic_sort=2): {+a[d>c>b>a>];+e[e>];+f[f>];+g[g>];+d[];%d(b(e(a()))a()g(c(a()f(b(e(a()))))));-d[];-g[];-f[];-e[];-a[ This triggers a regression without the actual fix in the subsequent patch. > The test needs to either be marked as xfail_output (and adjusted in the > patch that actually fixes it) or move to the subsequent patch. I'll adjust this in a next revision that combines everything so far. Thanks, Chung-Lin