From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by sourceware.org (Postfix) with ESMTPS id 43FC53858401 for ; Mon, 27 Dec 2021 20:31:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 43FC53858401 Received: by mail-ua1-x930.google.com with SMTP id i5so13674562uaq.10 for ; Mon, 27 Dec 2021 12:31:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1e+D6AbZzaaTqs8p4N6xYccWpXLPazPm3EXBsph6lS8=; b=2+lJmsIy1JYJLfSB9n8Cms1rHhL9Uxy2mVkbP3w0bW9EKzohYAplQTDnxR85fBe/kW PnJ/Y1Sx6P3aozZdTOyvXJ4kRCe1lRRFutENKA3OzyGMUbl/RMm2rCol/N/hBLmEtY/N OMyap/ss0/svOKso1RCIfn3lHqIxxlk7b21KAsJ4nUEbOREfrOua8RAODd9nlZXL3tDL FIj91F3v0vKgZt2F6zRjL9LBoecgKZ5Ad2D825k886R6ra/TlG9pEhObqqREy19BQ84y gzxbG93Ao68pIW4afDgYymtIVJQrRun64MF6VemNjIzPR8opVfcYE0/pHk5CwEyzJ1Jo GYuQ== X-Gm-Message-State: AOAM532YrUFzektmfjCBT6R/dlmT0qvKEeQUNWogqRo15H7ilv5zxJHj 3MT5mUpmwoChb6EGfIXmINpFjw== X-Google-Smtp-Source: ABdhPJzF57TlADzccFwTjeba6oKpUivovVpSXrXWblGm1sRq76WBT6hjrd0SVaej6hBJDLwWC5Dkdw== X-Received: by 2002:a67:f2c6:: with SMTP id a6mr5060231vsn.59.1640637114800; Mon, 27 Dec 2021 12:31:54 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:3b1e:f218:7987:80e2:7249? ([2804:431:c7cb:3b1e:f218:7987:80e2:7249]) by smtp.gmail.com with ESMTPSA id 92sm3124796uar.19.2021.12.27.12.31.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Dec 2021 12:31:54 -0800 (PST) Message-ID: Date: Mon, 27 Dec 2021 17:31:52 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v7 16/16] elf: Fix runtime linker auditing on aarch64 (BZ #26643) Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard References: <20211222132712.523295-1-adhemerval.zanella@linaro.org> <20211222132712.523295-17-adhemerval.zanella@linaro.org> <8735mh96mh.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <8735mh96mh.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Dec 2021 20:31:56 -0000 On 24/12/2021 15:53, Florian Weimer wrote: > * Adhemerval Zanella: > >> The aarch64 rtld audit support is change to: >> >> * Both La_aarch64_regs and La_aarch64_retval are expanded to include >> both x8 and the full sized NEON V registers, as defined by the >> ABI. >> >> * dl_runtime_profile needed to extract registers saved by >> _dl_runtime_resolve and put them into the new correctly sized >> La_aarch64_regs structure. >> >> * The LAV_CURRENT check is change to only accept new audit modules >> to avoid the undefined behavior of not save/restore x8. > > I forgot about the x8 issue. > > The commit message should mention the ABI change as the reason > for the LAV_CURRENT enforcement. I have added the bullet point on commit message: * Different than other architectures, audit modules older than LAV_CURRENT are rejected (both La_aarch64_regs and La_aarch64_retval changes layout and it does not work the complexity to support multiple audit interfaces). > Old audit modules could start working > on new glibc because the x8 bug is fixed unless they actually try to use > enter/exit hooks. I'm fine with not enabling this usage scenario (i.e., > rejecting old audit modules that could actually work). This should have > a NEWS entry, though. I added: * The audit interface on aarch64 is extended to support both the indirect result location register (x8) and NEON Q register. This makes old audit modules to be rejected by the loader. > > Thanks, > Florian >