public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH 5/5] s390: Use generic kernel_sigaction.h
Date: Tue, 18 Dec 2018 18:44:00 -0000	[thread overview]
Message-ID: <e63d4758-0325-1fb5-36c9-d858aa71f616@linaro.org> (raw)
In-Reply-To: <20181211195554.3377-5-adhemerval.zanella@linaro.org>

I will commit this shortly if no one opposes it.

On 11/12/2018 17:55, Adhemerval Zanella wrote:
> S390 kernel sigaction is the same as the Linux generic one.
> 
> Checked with a s390-linux-gnu and s390x-linux-gnu build.
> 
> 	* sysdeps/unix/sysv/linux/s390/kernel_sigaction.h: Use Linux generic
> 	kernel_sigction definition.
> ---
>  ChangeLog                                     |  3 ++
>  .../unix/sysv/linux/s390/kernel_sigaction.h   | 28 ++-----------------
>  2 files changed, 5 insertions(+), 26 deletions(-)
> 
> diff --git a/sysdeps/unix/sysv/linux/s390/kernel_sigaction.h b/sysdeps/unix/sysv/linux/s390/kernel_sigaction.h
> index 7a6a2c4f29..18000a62cc 100644
> --- a/sysdeps/unix/sysv/linux/s390/kernel_sigaction.h
> +++ b/sysdeps/unix/sysv/linux/s390/kernel_sigaction.h
> @@ -1,30 +1,6 @@
> -#include <bits/types/siginfo_t.h>
> -
> +/* S390 uses the generic Linux UAPI but defines SA_RESTORER.  */
>  #define SA_RESTORER	0x04000000
> -
> -/* This is the sigaction structure from the Linux 3.2 kernel.  */
> -struct kernel_sigaction
> -{
> -  union
> -  {
> -    __sighandler_t _sa_handler;
> -    void (*_sa_sigaction)(int, siginfo_t *, void *);
> -  } _u;
> -#define k_sa_handler _u._sa_handler
> -  /* The 'struct sigaction' definition in s390 kernel header
> -     arch/s390/include/uapi/asm/signal.h is used for __NR_rt_sigaction
> -     on 64 bits and for __NR_sigaction for 31 bits.
> -
> -     The expected layout for __NR_rt_sigaction for 31 bits is either
> -     'struct sigaction' from include/linux/signal_types.h or
> -     'struct compat_sigaction' from include/linux/compat.h.
> -
> -     So for __NR_rt_sigaction we can use the same layout for both s390x
> -     and s390.  */
> -  unsigned long sa_flags;
> -  void (*sa_restorer)(void);
> -  sigset_t sa_mask;
> -};
> +#include <sysdeps/unix/sysv/linux/kernel_sigaction.h>
>  
>  #define SET_SA_RESTORER(kact, act)             \
>    (kact)->sa_restorer = (act)->sa_restorer
> 

  reply	other threads:[~2018-12-18 18:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 19:56 [PATCH 1/5] m68k: Fix sigaction kernel definition (BZ #23960) Adhemerval Zanella
2018-12-11 19:56 ` [PATCH 5/5] s390: Use generic kernel_sigaction.h Adhemerval Zanella
2018-12-18 18:44   ` Adhemerval Zanella [this message]
2018-12-11 19:56 ` [PATCH 3/5] hppa: Remove kernel_sigaction.h Adhemerval Zanella
2018-12-18 18:28   ` Adhemerval Zanella
2018-12-11 19:56 ` [PATCH 4/5] ia64: " Adhemerval Zanella
2018-12-18 18:29   ` Adhemerval Zanella
2018-12-11 20:09 ` [PATCH 2/5] alpha: Use Linux generic sigaction implementation Adhemerval Zanella
2018-12-18 18:28   ` Adhemerval Zanella
2018-12-11 22:47 ` [PATCH 1/5] m68k: Fix sigaction kernel definition (BZ #23960) Andreas Schwab
2018-12-12 10:41   ` Adhemerval Zanella
2018-12-12 10:44     ` Andreas Schwab
2018-12-12 19:01       ` Adhemerval Zanella
2018-12-14 18:43         ` Andreas Schwab
2018-12-16 22:57         ` Aurelien Jarno
2018-12-17 12:06           ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e63d4758-0325-1fb5-36c9-d858aa71f616@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).