From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>,
GNU C Library <libc-alpha@sourceware.org>
Cc: nd@arm.com, Siddhesh Poyarekar <siddhesh@sourceware.org>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH 1/2] aarch64: Remove HWCAP_CPUID from HWCAP_IMPORTANT
Date: Fri, 29 Jun 2018 17:22:00 -0000 [thread overview]
Message-ID: <e653083b-a7d0-c1ab-2651-d6397cf3f180@gotplt.org> (raw)
In-Reply-To: <8a2283bd-a4e2-8009-db7e-a20b3772d1cc@arm.com>
On Friday 29 June 2018 09:43 PM, Szabolcs Nagy wrote:
> searching libraries in ".../cpuid" path or allowing cpuid
> based ifunc dispatch are quite different requirements, when
> HWCAP_CPUID is available i think those two should be possible
> to control independently (especially since searching "cpuid"
> is almost never wanted and the ifunc dispatch is almost always
> wanted).
>
> the generic code currently only uses the mask to affect the
> library search path, the intention may be different, but my
> statement is defacto true and i don't see a good reason to
> reuse the mask for something else that may have conflicting
> requirement.
This is a different argument and I don't disagree with it.
> ok, i will wait for feedback for a while, but if you don't
> have an objection i consider this change safe.
Thanks, I also believe the change is safe, just that I am not sure if
hwcap_mask is a more popular than tune.cpu to switch off ifuncs since I
haven't been in touch with distro development for a while. Hence my
request for more feedback.
Siddhesh
next prev parent reply other threads:[~2018-06-29 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 18:22 Szabolcs Nagy
2018-06-29 7:19 ` Siddhesh Poyarekar
2018-06-29 16:14 ` Szabolcs Nagy
2018-06-29 17:22 ` Siddhesh Poyarekar [this message]
2018-07-06 15:21 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e653083b-a7d0-c1ab-2651-d6397cf3f180@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
--cc=siddhesh@sourceware.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).