From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-78585-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 36440 invoked by alias); 12 Apr 2017 12:44:23 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 33298 invoked by uid 89); 12 Apr 2017 12:44:17 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=prot
X-HELO: mail-qk0-f172.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-transfer-encoding;
        bh=74mH84J80dEMJHALNACP2qHLjne9lkerRoI4/kZlcJA=;
        b=Dgw3hcn/jufKPqhFfe4VBTbbewronFYaJxjJDis1IpSvA9FgZMl0xsPm5me0yTV6H5
         m88Gx4Y5Zbfz54rCXfdILSKNsUokNFfD8A0EV/PfHPWKHzaqbipBEJkWUzQVYMFVCe+F
         2TetXkrmKSKy5OvKy4tPE+Gp3/eK9M4wZlewJ7/3gcuiCeNS6x3JMkp5uT0VV90EZeo1
         xQ6Eqr4U3BY9GOt1iCCjOxJm5nSjSMAd9MZ0k9DhJvoDYwl4dRJx8B8/C9Ogm/fcZmOe
         8dTDe9vJ3P6jkhcwFUXAIDme2h1mBYhSOAlTOWKciVDQSyOPpsHnomk17q0wxkfM2I0l
         Mlgg==
X-Gm-Message-State: AFeK/H1X/vG0whqYzy3AaB++NES2FsJ6ilId6sWE1iHJFfayObqv2UX5rp8SaJNDPxGSkqRU
X-Received: by 10.55.25.99 with SMTP id k96mr59280878qkh.161.1492001055964;
        Wed, 12 Apr 2017 05:44:15 -0700 (PDT)
Subject: Re: [PATCH] Consolidate Linux mmap implementation
To: libc-alpha@sourceware.org
References: <1490369962-29989-1-git-send-email-adhemerval.zanella@linaro.org>
 <87vaqy372c.fsf@linux-m68k.org>
 <ff1efa57-30ee-4c0f-76c3-784013f2d78c@linaro.org>
 <046eebcd-e906-6028-fce4-27ed6a95c1f5@linaro.org>
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Message-ID: <e6d1a735-a25c-d238-68aa-5b4b743cd803@linaro.org>
Date: Wed, 12 Apr 2017 12:44:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <046eebcd-e906-6028-fce4-27ed6a95c1f5@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-SW-Source: 2017-04/txt/msg00211.txt.bz2



On 06/04/2017 17:00, Adhemerval Zanella wrote:
> 
> 
> On 24/03/2017 14:57, Adhemerval Zanella wrote:
>>
>>
>> On 24/03/2017 14:42, Andreas Schwab wrote:
>>> On Mär 24 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
>>>
>>>> +void *
>>>> +__mmap (void *addr, size_t len, int prot, int flags, int fd, off_t offset)
>>>> +{
>>>> +  MMAP_CHECK_PAGE_UNIT
>>>
>>> I think it would be better to define this as a function style macro.
>>>
>>> Andreas.
>>>
>>
>> I do not have preference here, I changed to:
>>
>> # define MMAP_CHECK_PAGE_UNIT() ...
>>
> 
> Ping.
> 

Any objection for this patch? Otherwise I will commit it soon.