From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by sourceware.org (Postfix) with ESMTPS id 59C8F3857020 for ; Mon, 15 Feb 2021 16:39:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 59C8F3857020 Received: by mail-qk1-x729.google.com with SMTP id f17so6906655qkl.5 for ; Mon, 15 Feb 2021 08:39:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:autocrypt:subject:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2wyV73PAmktVyw0xRng+DCSpYLL/nu98v9QLsRboHtc=; b=AYPeOlAYR7tjks4EAyMMreUO7x7Qr9FiACcSm+hKfBQ+mXDo1fKS8PHVleP8z9gxyV 3+ob556+ZWt1gMHGsx9E3afUIbAeeNsX5rrq0n+lf2qtGewsJb4hNiP9ZxzJBtM6Sn1m C4AGKoY7Z3zH1YKoKMuY2om+BL+wbQfkbmnhjABdcamkoxKP27yO3HQtAjnALMTX/0dW IEKt6IPWptmYglu5rbmCBVyyesLaxcJDoVhFhKG5nlSixABX4WXJBfcYAlq2lnSRL5mj DgJvFBKtEM9mFB127MqbZHJR1Egj7qyD4K5zkcUYnRVChb+2IGkdmDVZatgBnDyGFe3/ tNNg== X-Gm-Message-State: AOAM531AyjAn4UJsAaWQBk8DMgEUw+ox+Dmd0zYKAvVrXr1fCkvjsKm9 f18iQvqyEqcSMLmU7nIQTKvcEv57BXfx5Q== X-Google-Smtp-Source: ABdhPJxpgCvqbAxY5y/I1PX1LTsrctGWdNjwC2r8FbrpoGY8N+UP1JbWYYYtgrtpBaVrM0Joj/b67Q== X-Received: by 2002:a37:9b51:: with SMTP id d78mr15565800qke.333.1613407144857; Mon, 15 Feb 2021 08:39:04 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id f11sm4621901qtc.53.2021.02.15.08.39.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Feb 2021 08:39:04 -0800 (PST) To: Naohiro Tamura , libc-alpha@sourceware.org, Mike Frysinger References: <20210215123137.204048-1-naohirot@fujitsu.com> <0820aeae-41c4-e751-e6b2-aaa83921fc41@linaro.org> <060cf851-b2c9-a608-7dbb-7f7a4636ea6a@linaro.org> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Subject: Re: [PATCH] Replaced obsoleted AC_HELP_STRING to AS_HELP_STRING Message-ID: Date: Mon, 15 Feb 2021 13:39:01 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 16:39:06 -0000 On 15/02/2021 12:38, Mike Frysinger wrote: > On 15 Feb 2021 10:39, Adhemerval Zanella wrote: >> On 15/02/2021 10:29, Mike Frysinger wrote: >>> On 15 Feb 2021 09:59, Adhemerval Zanella via Libc-alpha wrote: >>>> On 15/02/2021 09:31, Naohiro Tamura wrote: >>>>> This patch replaced obsoleted AC_HELP_STRING to AS_HELP_STRING. >>>>> As of Glibc 2.33, INSTALL says "GNU 'autoconf' 2.69 (exactly)" is >>>>> required. So we can safely replace obsoleted macro without worrying >>>>> about older autoconf. >>>>> This change doesn't affect the contents of "configure" file. >>>> >>>> If this does not change or improve configure, why change configure.ac >>>> then? >>> >>> why wait for autoconf to start warning that we're using a deprecated >>> macro and failing the build or confusing devs ? >>> >>> patch LGTM >> >> Because we use a macro to test for the specific autoconf version: > > that's not an argument for continuing to use deprecated macros > >> aclocal.m4: >> >> 5 m4_define([GLIBC_AUTOCONF_VERSION], [2.69]) >> 6 m4_if(m4_defn([AC_AUTOCONF_VERSION]), GLIBC_AUTOCONF_VERSION, [], >> 7 [m4_fatal(m4_flatten( >> 8 Exactly version GLIBC_AUTOCONF_VERSION of Autoconf is required but you have >> 9 m4_defn([AC_AUTOCONF_VERSION]) >> >> So autoconf will start to fail or dumping a warning only if the >> distro actually patch it to do so. >> >> I don't have a strong opinion about this patch, but due the *current* >> constraints of the auto-generation (which requires an specific autoconf >> version), this patch does not improve anything really. > > the macro is clearly deprecated upstream. the version we're pinned to supports > the non-deprecated version. i don't see why we're debating this. > > it's a lot easier to upgrade versions when you don't have to dig through a pile > of warnings in the process. if people want to do migrations ahead of time (and > have even written the patches), then let's merge them. Again, I don't have a strong opinion about it so I not following your slight aggressive tone here. I just initially asked *why* change it, since we already have a specific check for the version so any version migration would require to check if these macros indeed would break something (and I agree with you that this would make easier to upgrade). In any case, it seems that the configure.ac already use a mix of both the macro and the deprecated one, so it should be fix. Also please fix it on the aclocal.m4 as well.