From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128758 invoked by alias); 19 Mar 2018 14:25:39 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 128747 invoked by uid 89); 19 Mar 2018 14:25:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR02-HE1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs.Nagy@arm.com; Cc: nd@arm.com, "H.J. Lu" , libc-alpha , Max Horn , thomas@grindinggear.com Subject: Re: [PATCH] Fix i386 memmove issue [BZ #22644] To: Florian Weimer , Andreas Schwab , Andrew Senkevich References: <597954a1-85da-e524-1454-27c46af57413@redhat.com> From: Szabolcs Nagy Message-ID: Date: Mon, 19 Mar 2018 14:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <597954a1-85da-e524-1454-27c46af57413@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0202CA0041.eurprd02.prod.outlook.com (2603:10a6:4:a5::27) To VI1PR08MB3294.eurprd08.prod.outlook.com (2603:10a6:803:3e::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7ec2794c-78bb-4667-4080-08d58da5461c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:VI1PR08MB3294; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB3294;3:sY85aA8bLRXXcd/hX9o4Nx5/s+QP9cW6BSEJoBl6CfN6+Q9LTqP/lEGA9N9Xmlr/pHNIxAxE2X1Q3K4zggPdMUwN+fsvOAk9QasA0qF/foA8Bjx4E6O88AbV1AyhzGvwrHu56ZZBbXVioH3CS3xo9/4Bpz/yxXt73+h7lWU1IpvtmWe82GMWQRLa6U//qSc08cYHOuCZVG6aSTTq9wdAP74KealHcn7NpOpEztv/3hbH6oDQgM/kDvLtHAXtym1a;25:JzDB2fUETEQvXt65q2wOtPfGy7kX7a4OchNZUlRpq8yeulejOVwyMaECtsyItnhnn7+nKvOrSKzQ8dkNG5bWHh4Bec/Pq8bAV9JLyTenNFtFcJH9Ng20fVcnt3yVE6X/QP3eNgXTXHKsnko/bfm6+DZRXPIlg5vv/0OhcezRoqONG8HHJjFSgEMixNw/wo1GERe2Pdp9vhVMZCb38y9qKNKbman6bCOfbKGTKv+ODyJF97Wi2jM5dJSHMCEMDaCKZSNiPl+Oy4ThAeg00GkBHJXzqJ36q3LXC1KCsSp/+IqfSET6sUqWKA36v/yQX8wRBGr+WcjbOzMLpAOXp0oFdQ==;31:K4VMeUHqdzC562X8gHoQfaVakmjQ6JrV2I8jiCzELQhboiNp4pTszDA/htrfOcZ6AvvQJVUFkvS8cGbyLkaWglFxUHzkxUFNH5T3Mm+gjh5n0VJslJdrjssJY1K748rYfZkT5T63kcQfsVpTbD1fE1Kn4kDKgWuBlZshw9n747rgsQslfdUXip66bMfvsQH1gfEvzBGc+pdNkrfzh1vmdxXcsRK1vt5IAt7GZr3d0+M= X-MS-TrafficTypeDiagnostic: VI1PR08MB3294: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB3294;20:NvwOX89915YtBdV2n0u8x9HT1vvk2kzeD7noTdSx+WEo/T1rr7VISSLIvow6IxvimbIxbunEZ4KLDP3+RzVS5S3HFx10Y61JtDOA4XpXhsqemfPQVEUDnPseVCXusFwpgYKQxW8hYj4X3PX+Ugl1SZrNlc0WYwmarE1f6cU4g7I=;4:+shyl6bdIupBNVQNvcB4dSJ+RYhGKtALpIyb44zm5MEIasxPXBc3REa6k68CJjDOxtKE/SkMqG39Gh4+3twwdN2toMuVScZoIijISOs8ri/xfjQQtfEH3rLX699bzJczGBGsjJycJisJz47nYR23aoBhVfaVN9ABLc487GFK1upH7Oe3d+jDtWmcYRCFhuFmvyf99fBwMQ/28DueHRGjZJkSymR2gF5PlgcNDTFm6RU6zQKW0nO9+1SXSIx1JDT6lOx/BjjibABOf3dVsKww3jAkLhL/jKYMNWAeuUJU3gMGkv9ibFUZQ5FcXviGZQY2 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(85827821059158); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501244)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(6072148)(201708071742011);SRVR:VI1PR08MB3294;BCL:0;PCL:0;RULEID:;SRVR:VI1PR08MB3294; X-Forefront-PRVS: 06167FAD59 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39380400002)(366004)(376002)(396003)(39860400002)(346002)(199004)(189003)(2950100002)(6486002)(16526019)(478600001)(72206003)(186003)(77096007)(26005)(31696002)(305945005)(53936002)(64126003)(31686004)(86362001)(386003)(39060400002)(2870700001)(6666003)(58126008)(110136005)(50466002)(97736004)(47776003)(76176011)(65956001)(65806001)(4326008)(66066001)(316002)(8936002)(105586002)(6246003)(93886005)(7736002)(52146003)(23676004)(2486003)(25786009)(68736007)(5660300001)(8676002)(3846002)(52116002)(229853002)(16576012)(106356001)(53546011)(2906002)(81166006)(36756003)(54906003)(65826007)(81156014)(67846002)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB3294;H:[10.2.206.230];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA4TUIzMjk0OzIzOkxOQ1R6RW8ydEUyRjIweGluU2V6aEVUUHVE?= =?utf-8?B?V09ScmdSaWtta2VoUVo3N2FZUzY2N3cxU2QvK05GeFlrRitGMnVxSDlObkg1?= =?utf-8?B?dERFbTdRRjNuTFNLRjVDN05RNitIaWxSa1pGdGhxZUVaZ3haamlkWlBCTmNu?= =?utf-8?B?eXYvaFhocGVUb0wrMDhRaHhqWjJkelhpRXM0YnAvSlBlLzVZU3JyS1NYK0Fv?= =?utf-8?B?c3dKMEl5QnR3NUt5RXdXS2NReE9NLzhOYllhazlNZTNoL0NOUTlwcDZON1dC?= =?utf-8?B?Mk9lMVE1VUc1bGxtL0tLMzRYVHM4N29RcFN5Qkd3cXorZUxadFkrRTIxR3dQ?= =?utf-8?B?aUlzaDVnU0ZiRkNXQVJQUmJJT0MwRVlndnVMY0dXRGVUQUl0ZXFsUlFLWlZP?= =?utf-8?B?d2JXaFdkb1FFamRUREFkdlFZK3JSSHA3enRlcHZWeXFBWVMrMG1zbkRqakFh?= =?utf-8?B?YUNKckNtZGhMNzByT0dGOFBLeWZUb2JmSVhpNjZtL0I3dzJzelJUQnJuc1VU?= =?utf-8?B?RGg3cDBRTndObDlLNG4zL3dOSHl0REUwRHB2R3NNNS9CT2E5S2V0MEVBTVZp?= =?utf-8?B?eTV2SnpVa3Q2OWE1d3gzRC9uMG11ai9wV050Ly90ZEM5SmQwVWFNOElEYTlz?= =?utf-8?B?OE5xSGs3a0FhT055cDVaVE9lNmEvZkM3QXJTdFZ2Nks0dTZPS005bld0NGhR?= =?utf-8?B?WjhGUmZLZjY0U3psRzE4ZW5Vd1hBV0dLVk1JSDB2QStpVUdrRGVRbk13Y3Jz?= =?utf-8?B?bC9udVFqRVVyUGJmZEt6bVE3NXZqa05iQVdDdGg4MWgzTEoyU1E1SytvOTc1?= =?utf-8?B?S1BEaU9DRFUraXhjczhoajBnSGVPVkROWStVMTdOczBxKzJEL1FJNEo0ZnBu?= =?utf-8?B?NGdzMng3S0dvK2FzQ2lPOTAyemN0NUR0SHNNM1ZYU3dNOHdvTEliMVpma042?= =?utf-8?B?SHZyaDhKanJUdTlBMkpUUzliOXhlWlBZTUdWU3pHenVoeXo4MVBPcFRoTDFs?= =?utf-8?B?TnI2N2toVTRaTkZlZ2I0Q0JVVUhIaW95WWx0Rm5jd0NML2x2TXIwcTNaVXFK?= =?utf-8?B?U1VLZWpFU1EwVEU5UGhDMTYyYXlvYjNFb3hIRGdEZjBkbWdVNk05Zmw0ZGRW?= =?utf-8?B?Tmd3d0NLWlpyVE1oQmQzK2w0TWNnVGNGYnVLWi96aHFhVVJiZnB6ZUtQRWI1?= =?utf-8?B?VTh0MUUwbmFEQmZram1mME5reDFPVW9HR2R1bkhoc2Q1elNiK2hRRDc2c21m?= =?utf-8?B?L2lzNEJSN3kvNjlZdUMva2hHT05HVExXVGhWbWFqaXEvMDVtbEQ1TEZWZUdq?= =?utf-8?B?eFY1ZlRtWnkzS0UxRnRzZEQ5Y0MycTdXQWJENmFoYmJwSytqcG8yYkdiUm9Z?= =?utf-8?B?RExqMk1UY3RyMUdiL0dXVFpWdGdOWlJQbEQ1bjRRb3J2eHViSWlieHVuQi9t?= =?utf-8?B?MkwxT1R0R25UbnFNM2tTMGlrVVpidEJsamY1SzdqTzMrQkJ4WG9nNWMrSk5U?= =?utf-8?B?QjhOTlM0RzlqdEZrOGY3ZFQ4a091WUFnM2pSdXlOakRHRWtUdWNoS0FWa0h4?= =?utf-8?B?cVQ3V3drNGk0d2hFZDkzSmxTZStRTk51TXNMbWhkV2g1MGR1MTBUYzhrTXdq?= =?utf-8?B?Zk1OOG1hcUhiWHF6Sk96Ni9tVFo0V1BHc1NNb24rUjdYQ3JHWThQVkNFU1pn?= =?utf-8?B?WVAweFpqMDIyN1FzemYvc0V3dkJjMm9PaVRBM3VmbEtic0JiVjFpRlR0ZmJM?= =?utf-8?B?Vld3Yk51enRBVGI3Vm5uaVFHNVhtam5ETUJyQWIyWHp0MWI1STNFNWtxZ3NU?= =?utf-8?B?VkhxSUR3dG5SbjQ1aUdqQkFJM0lqVEZRRVR1MEZYU2sydW03TWt2NVI4RitH?= =?utf-8?B?eTZtM1Q5NW1CVzJWRFNHT1VmZVF2RWJ0OEp6Tzk3aHgzRS9qSWJhbnE3SFI1?= =?utf-8?Q?yH8IMVMZfpXNZP6xsvUPYxTWadpOVw=3D?= X-Microsoft-Antispam-Message-Info: M2bbQLQe9pj3DnQs4pFFbcUgO2SvI5sAWvMu04OAPLbcwAqMK+guSeLJ8lvYpalzc8rNKTVbm80IHBEfpp1y+xk122UWHBSbaKfmVI4NmS5mKYYtH6o0gAIaXB72DSZpGgFUoTyws/6DUPc9uCqCbL05afxvQ3E+8hkW/OvMIDg+15DpDD5CilcJmmXzoHCv X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB3294;6:LTMo0qb9p2fs7o/hRWuU1YIhU+61CT75TNJP/L0/neUY3k9bhPcXTTqwBJ39qufn5cRqAO5bqYkwKXiiPHjOOusRIuD/mYoZuKOU/0GeHJpMQvkivWKyAYhU13BgoAvT378zXd9r3v2AkSnsSwrW2FDcLsWRjf3fMX6avjD1XTMuNMA0w3IDeJRbB1mgqUNcoT8hOHOnhiXr1oCjbE/coNJethbSzvl1LYwtoTmNbbNVcK3Z6Jit00Es4ovH+pk0ZGI7OEESgLGynIMsNSikFQ66XpMLG44Pgj2f/wQGVggA9hsRDpVzJjVxQ+0EBGWMr5fdTfvAo2gl39GhOWSpq4LWsrtRriFfpoCNO1vGTWA=;5:N2QBo+o72FJEyrcvqzkqGYWINga4f7B4bGpR4V+Z640OD/IBsyr9+eZVouCHyo0OUYRjYwBwzC83wmQfnfrJ28k2pyCc9xzJh8KL0pOokj9N4DXWh0F6845O/iZ2B32mR0Rqun1DHk8348B+S1j36Xb4VWwvS7ERZFqS55epeHk=;24:MWLOHsSTVaLg8V4YYE1YoG/+LA6if4wced3+FneC8JPXWyPpckAz10bFEiF45my8tuBIcM4RHGJ47Og+jjy+UUAc9o0O6z781nWUrZr2r+A=;7:5nEQNWsohdbxk25NZ5QdCfGrQpinB4Gv7RXHXtHmDfeW75BciOVl2dZXxQy3oV53e5q8UD9tRlal8Pj/ViZvic5ETMYDwrFwlF5Pi1AqDzMHR2tFf0MY15weIBA4sKjqXg7TwDPvUntWYG/bTZQqP6l57oETM5OV26i8tPwt6JG4quJfLdkRjCQQ/Vk9krQDLetHVwMQOrztFRFo/jkVsF8n6ckSHmgaEuOl4Hb42YGpOQ/OqZUtIgbZJJTuMzjn SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2018 14:25:32.1295 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7ec2794c-78bb-4667-4080-08d58da5461c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3294 X-SW-Source: 2018-03/txt/msg00455.txt.bz2 On 19/03/18 13:17, Florian Weimer wrote: > On 03/19/2018 02:11 PM, Andreas Schwab wrote: >> On Mär 19 2018, Andrew Senkevich  wrote: >> >>> +static void >>> +do_test2 (void) >>> +{ >>> +  uint32_t num = 0x20000000; >>> +  uint32_t * large_buf; >>> + >>> +  large_buf = mmap ((void*)0x70000000, num, PROT_READ | PROT_WRITE, >>> +     MAP_PRIVATE | MAP_ANON | MAP_FIXED, -1, 0); >> Since you are using MAP_FIXED this may overwrite an existing mapping. > > Leading to a hard-to-debug crash, maybe sporadically due to ASLR.  Yes, I have this concern as well. > > There was a long, long Linux thread about a non-overriding MAP_FIXED variant, but as far as I can see, this has not been merged.  Maybe it would > have helped here. > i thought not using MAP_FIXED is the 'non-overriding MAP_FIXED variant' if you use an address hint then the kernel will use that unless it's not available and you can check the result.