From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 5AE273858C83 for ; Thu, 20 Apr 2023 15:51:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5AE273858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-6a5ecdb455bso428032a34.0 for ; Thu, 20 Apr 2023 08:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682005882; x=1684597882; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4KGGIERKmUa+JYGCYjZhihoDsRSX3eFToREWg6k6nlg=; b=b9ZBTeXoGtEF2bsFztd8CBOxcv9KOuCkZYCnz1NAo0VujuOywXJtyG+SYAJAjpMuAk y3AMSt+eRfHTSoui6krBmYnt5hX72lRbAkdHGdPX2cX+RSuRUngK5tg2Dp9zOfRIpe8c 44osJCLDw+NtnnO9UNTu6jnCIn8MuYLsGufaOu6xPE3YC1n9fWV0Xfn//OHVKqzu2FVX xLo51xXmtvtROUCTdiy2rFJzU93St0eBwspi3nx8b8+syykB32+Xcop7F1wP+0ETOai9 80D2jVJ4JapeibS200Eg2kCjBcIbhlR05FW2nlHbAThPlIglfldWc+4ovPOs7rBrPW3I ImpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682005882; x=1684597882; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4KGGIERKmUa+JYGCYjZhihoDsRSX3eFToREWg6k6nlg=; b=GvWm+q++djGqBAS9hZWYuFC5MwJBsQSmSMKFx6XbGORPxIF5EXNGag2BTEgTYP56YP /4OF9r/v/K2MhRtB7fgkaSATBZ+EKU1ZzAXdm45GLfTssKk5awfn4ktR2j3mnKeEphZj YhHqc/94NXW7PB8CuE3vL9PJh3l27vRbK6FgA92xYImHkdn3sBtjOxeY/LT5qBmIqaYt 5/srJT1IQGXB70fcIwOt3RFFjckL4a/A+oJ7RoTzRCNGmmn1nP5Jl4v31Hs9IUt6/uqk 8xwpXSw8ocqefgpE9cpLpdN3Ag0zba5W5s2mBvTsurNHhHNVLS+M2CpgOIzWEhT9DhX0 yP5A== X-Gm-Message-State: AAQBX9efxHaH83woyc6swi/ttsuSzBBZTL8gxa1o1NfqaxNcZnzhRHeo wWP1VbUPt7WrK5GG8q8wrXiNxQ== X-Google-Smtp-Source: AKy350ZRCxmyQwaARWI8jy/szA0SkEPiASWjLrLKoJdN6VzrqeNxLNgP68TanY82ka2cr2+3vCBQqQ== X-Received: by 2002:a05:6830:1d73:b0:6a5:e895:1bdb with SMTP id l19-20020a0568301d7300b006a5e8951bdbmr894812oti.35.1682005882745; Thu, 20 Apr 2023 08:51:22 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c3:333:20b7:b016:1b7f:fd25? ([2804:1b3:a7c3:333:20b7:b016:1b7f:fd25]) by smtp.gmail.com with ESMTPSA id r18-20020a056830135200b006a612ee5b1csm842406otq.40.2023.04.20.08.51.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Apr 2023 08:51:22 -0700 (PDT) Message-ID: Date: Thu, 20 Apr 2023 12:51:19 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5 2/4] string: Add tests for strdup (BZ #30266) Content-Language: en-US To: Joe Simmons-Talbott , libc-alpha@sourceware.org References: <20230329150500.2886135-1-josimmon@redhat.com> <20230411190526.2469122-1-josimmon@redhat.com> <20230411190526.2469122-3-josimmon@redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20230411190526.2469122-3-josimmon@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/04/23 16:05, Joe Simmons-Talbott wrote: > Copy strcpy tests for strdup. Covers some basic testcases with random > strings. Add a zero-length string testcase. > > Reviewed-by: Adhemerval Zanella Just minor nits I saw it on a second look. > + > +static void > +do_random_tests (void) > +{ > + size_t i, j, n, align1, align2, len; > + UCHAR *p1 = (UCHAR *) (buf1 + page_size) - 512; > + UCHAR *res; Use CHAR here, so there is no need to cast ... > + > + res = (UCHAR *) STRDUP((CHAR *) p1 + align1); > + TCS ((CHAR *) res, (CHAR *) (p1 + align1)); ... here.