From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v3] glibcextract.py: Add compile_c_snippet
Date: Thu, 11 Aug 2022 08:21:18 -0300 [thread overview]
Message-ID: <e8bf432a-51c7-0abc-17d8-d31b495bc336@linaro.org> (raw)
In-Reply-To: <8735e3xpq8.fsf@oldenburg.str.redhat.com>
On 11/08/22 03:23, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> It might be used on tests to check if a snippet build with the provided
>> compiler and flags.
>> ---
>> scripts/glibcextract.py | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>>
>> diff --git a/scripts/glibcextract.py b/scripts/glibcextract.py
>> index 43ab58ffe2..78735fad43 100644
>> --- a/scripts/glibcextract.py
>> +++ b/scripts/glibcextract.py
>> @@ -17,6 +17,7 @@
>> # License along with the GNU C Library; if not, see
>> # <https://www.gnu.org/licenses/>.
>>
>> +import collections
>> import os.path
>> import re
>> import subprocess
>> @@ -173,3 +174,22 @@ def compare_macro_consts(source_1, source_2, cc, macro_re, exclude_re=None,
>> if not allow_extra_2:
>> ret = 1
>> return ret
>> +
>> +CompileResult = collections.namedtuple("CompileResult", "returncode output")
>> +
>> +def compile_c_snippet(snippet, cc, extra_cc_args=''):
>> + """Compile and return whether the SNIPPET can be build with CC along
>> + EXTRA_CC_ARGS compiler flags. Return a CompileResult with RETURNCODE
>> + being 0 for success, or the failure value and the compiler output.
>> + """
>> + with tempfile.TemporaryDirectory() as temp_dir:
>> + c_file_name = os.path.join(temp_dir, 'test.c')
>> + obj_file_name = os.path.join(temp_dir, 'test.o')
>> + with open(c_file_name, 'w') as c_file:
>> + c_file.write(snippet + '\n')
>> + cmd = cc.split()
>> + if len(extra_cc_args) > 0:
>> + cmd += [extra_cc_args]
>> + cmd += ['-c', '-o', obj_file_name, c_file_name]
>> + r = subprocess.run(cmd, capture_output=True)
>> + return CompileResult(r.returncode, r.stderr)
>
> Sadly that doesn't work because extra_cc_args isn't split.
It even simplify the code in fact, I will send an update.
>
> Maybe we should just keep using the shell (without the redirect).
>
> Thanks,
> Florian
>
prev parent reply other threads:[~2022-08-11 11:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 19:24 Adhemerval Zanella
2022-08-11 6:23 ` Florian Weimer
2022-08-11 11:21 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8bf432a-51c7-0abc-17d8-d31b495bc336@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).