From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 10E083870852 for ; Tue, 2 Jun 2020 03:28:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 10E083870852 Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-487-U09Av_ArPdKzshJZD6P5yQ-1; Mon, 01 Jun 2020 23:28:06 -0400 X-MC-Unique: U09Av_ArPdKzshJZD6P5yQ-1 Received: by mail-qv1-f72.google.com with SMTP id j4so2184464qvt.20 for ; Mon, 01 Jun 2020 20:28:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=upl/IqnX3hs2/EtnelvZxTwq30eioSoEvyHlkF+3ErU=; b=aNZ9QBL0Yb/Q/zaVDcyST1xGjYzzAVUMj4H5HwWhHM1UOM4ZpM9jNhhYyyZJ15iNjK YJ1FTDNwigkdakNi++tyEmprHy2BH2ERMlZgnTlx2zCt7aia+/XBXlaEMBXCUOSSssEf Vod6BdMOtCLBbsJ9d88n4cGgOuKPCiwe3WGtzSBVWp/WHo2chOiF6IpZ2DZP0qQH5roI fmB6wGQqvuvbRhq8OhaEJTVutQaXmuzafKQeKfFoNVg/ECoixfKt56pv7aCugf3tKM4F wBdSZz+TfvBauUqbaKNJRdf1neE4oY5dRCGV69gFQmGmN0r1kAmGNEw+MyTcID5bVZE9 RkAQ== X-Gm-Message-State: AOAM532ys7nSbtC0kfFP3pga4CHotCT4Bs/7yleRESictdXDdydwZcLS W4iSLJUJMHvWvydBdhIAZLy6rnLQIfuIlE1pL82JNS7pFmjtqR9Sfo4FxU14QDVilTSEixV2Ndi pHfNgku2pvoyNjR42hLUJ X-Received: by 2002:ad4:55b4:: with SMTP id f20mr16847919qvx.148.1591068485309; Mon, 01 Jun 2020 20:28:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxc0qpeMzpU/kSB31lLsfWDKBbKi7taj+cGtmbaix4B79luJGGWV2aWahfbFbbs9yKiyexSqQ== X-Received: by 2002:ad4:55b4:: with SMTP id f20mr16847910qvx.148.1591068485107; Mon, 01 Jun 2020 20:28:05 -0700 (PDT) Received: from [192.168.1.4] (198-84-170-103.cpe.teksavvy.com. [198.84.170.103]) by smtp.gmail.com with ESMTPSA id o6sm1180186qkh.28.2020.06.01.20.28.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2020 20:28:04 -0700 (PDT) Subject: Re: [PATCH 11/19] nptl: Add internal alias __pthread_getattr_default_np To: Florian Weimer , libc-alpha@sourceware.org References: <0d9514580a754c473ca8d4dbd325e3e888629c6e.1589884403.git.fweimer@redhat.com> From: Carlos O'Donell Organization: Red Hat Message-ID: Date: Mon, 1 Jun 2020 23:28:03 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <0d9514580a754c473ca8d4dbd325e3e888629c6e.1589884403.git.fweimer@redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2020 03:28:09 -0000 On 5/19/20 6:44 AM, Florian Weimer via Libc-alpha wrote: OK for master. Reviewed-by: Carlos O'Donell > --- > nptl/Versions | 1 + > nptl/pthreadP.h | 2 ++ > nptl/pthread_getattr_default_np.c | 4 +++- > 3 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/nptl/Versions b/nptl/Versions > index 4c7b43354d..e4696c128f 100644 > --- a/nptl/Versions > +++ b/nptl/Versions > @@ -61,6 +61,7 @@ libc { > __pthread_attr_setaffinity_np; > __pthread_attr_init; __pthread_attr_destroy; > __pthread_attr_copy; > + __pthread_getattr_default_np; OK. > } > } > > diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h > index 41b693d034..9c6dd41b7c 100644 > --- a/nptl/pthreadP.h > +++ b/nptl/pthreadP.h > @@ -437,6 +437,8 @@ extern int __pthread_attr_setstack (pthread_attr_t *__attr, void *__stackaddr, > size_t __stacksize); > int __pthread_attr_setaffinity_np (pthread_attr_t *, size_t, const cpu_set_t *); > libc_hidden_proto (__pthread_attr_setaffinity_np) > +extern __typeof (pthread_getattr_default_np) __pthread_getattr_default_np; > +libpthread_hidden_proto (__pthread_getattr_default_np) OK. > extern int __pthread_rwlock_init (pthread_rwlock_t *__restrict __rwlock, > const pthread_rwlockattr_t *__restrict > __attr); > diff --git a/nptl/pthread_getattr_default_np.c b/nptl/pthread_getattr_default_np.c > index a9665c5df7..5c99f980e2 100644 > --- a/nptl/pthread_getattr_default_np.c > +++ b/nptl/pthread_getattr_default_np.c > @@ -19,7 +19,7 @@ > #include > > int > -pthread_getattr_default_np (pthread_attr_t *out) > +__pthread_getattr_default_np (pthread_attr_t *out) > { > lll_lock (__default_pthread_attr_lock, LLL_PRIVATE); > int ret = __pthread_attr_copy (out, > @@ -27,3 +27,5 @@ pthread_getattr_default_np (pthread_attr_t *out) > lll_unlock (__default_pthread_attr_lock, LLL_PRIVATE); > return ret; > } > +libpthread_hidden_def (__pthread_getattr_default_np) > +weak_alias (__pthread_getattr_default_np, pthread_getattr_default_np) OK. > -- Cheers, Carlos.